-
Notifications
You must be signed in to change notification settings - Fork 64
Conversation
28f5a82
to
0aa80db
Compare
testPathIgnorePatterns: ['/e2e/'], | ||
collectCoverage: true, | ||
collectCoverage: false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because we had two scripts passing collectCoverage=false
in our package.json and only one script that actually cared about coverage, I figured it made more sense to enable it on a script-by-script basis when it is needed instead of disabling it everywhere that it doesn't make sense to have/is annoying to have.
@obulat I'm looking into refactoring the usage of Would it be correct that we just need to move the logic inside the callback passed to |
Another complication for us: nuxt/bridge#294
Update: After a little more reading, we could use |
Closing this PR. It was a useful proof of concept and I think we learned a lot from this exercise, but for the time being upgrading to Nuxt 3/Bridge is just not in our best interest. We can re-evaluate the upgrade path once the APIs for Nuxt 3 stabilize. |
Description
Partial upgrade to Nuxt3 via the
bridge
: https://v3.nuxtjs.org/getting-started/bridgeDoes a whole bunch of stuff to make this possible. I made notes in the code when relevant (like moving
env
anddev
out ofnuxt.config.ts
).Main changes:
nuxt.config.js
to TypeScripttsconfig.json
that extends thenuxt
one (only generated after runningnuxi dev
) based on the one used in Gutenberg@nuxtjs/composition-api
with#app
, the alias fornuxt
andvue3
dependencies (this is not really well documented yet anywhere in the Nuxt3/bridge documentation. I had to do some digging to figure this out on my own. There is this issue to document the migration from@nuxtjs/composition-api
that I suspect will address that particular problem: Document migration guide from@nuxtjs/composition-api
nuxt/bridge#209)Testing Instructions
Checkout this branch and run
rm -rf node_modules && npm install
. It's wise to remove thenode_modules
folder I think to avoid any potential for dependency overlap (shouldn't be an issue on subsequent installs). Then runnpm run dev
and verify the site loads. It won't work fully beause ofuseFetch
but otherwise it should be okay.Currently unit tests fail due to: https://github.com/nuxt/framework/discussions/1329
We also need to do some refactoring to update uses of
useFetch
as it is unavailable inbridge
: nuxt/bridge#211Checklist
Update index.md
).main
) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin