-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Async Django app #2663
Closed
Closed
Async Django app #2663
Commits on Jul 21, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 84c81d7 - Browse repository at this point
Copy the full SHA 84c81d7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 36d16fc - Browse repository at this point
Copy the full SHA 36d16fcView commit details -
Configuration menu - View commit details
-
Copy full SHA for cd6e699 - Browse repository at this point
Copy the full SHA cd6e699View commit details -
Configuration menu - View commit details
-
Copy full SHA for b1bbc1d - Browse repository at this point
Copy the full SHA b1bbc1dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8d5dd60 - Browse repository at this point
Copy the full SHA 8d5dd60View commit details -
Configuration menu - View commit details
-
Copy full SHA for dd68ca2 - Browse repository at this point
Copy the full SHA dd68ca2View commit details
Commits on Jul 24, 2023
-
Now that we use pytest-asyncio, it is easier to test the dead links in an async context and not need to worry about weird issues with the aiohttp client session being used outside of an async context. The places where the function was being called before (only one, in search) can now call `sync_check_dead_links` instead without any change to the overall behaviour of the app. It just makes the tests easier to configure now that we actually have real async contexts going on in some places.
Configuration menu - View commit details
-
Copy full SHA for 0ed63f5 - Browse repository at this point
Copy the full SHA 0ed63f5View commit details -
Try various things to fix the event loop closure, make a mess
It is worth reverting the httpx addition back to the aiohttp version. Use the same implementation of `get_aiohttp_session` but actually use `aiohttp.ClientSession` instead. Pass `session.close` instead of `aclose` to the application shutdown callback. Everything else is basically the same. You will see the issues I have noted in the PR comment of the event loop closing if you replace the `web` service command in docker-compose with `gunicorn --reload`. The rest of the relevant configuration will get picked up from the gunicorn configuration file.
Configuration menu - View commit details
-
Copy full SHA for 980ef96 - Browse repository at this point
Copy the full SHA 980ef96View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.