-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Block Theme: A quick design review / Design QA #633
Comments
- Update search placeholder - Update single pattern header font - Add a min-width to the copy button - Use filled/empty stars for favorites - Use a smaller border radius for pattern preview - Update footer Fixes #633
I've addressed most of this in the PR, so I'm going to close the issue.
Leaving this out for now since it's not a final decision— if we want to do a full copy review, that can happen any time.
This is phrased as a suggestion here, but since this would require a bit more custom code, I'd like to figure out if it's a hard requirement before spending the time.
Since the container is flexible, a min-height would cause other issues— if we did a 5-line min-height it would look really strange when both containers are 4 lines (at 1600 wide). You could try working with marketing to get 3 lines of text at some size, but the container will still be responsive.
The pattern creator is separate from the theme, but I do have a follow-up PR ready to go that will fix this once the theme is merged. Everything else should be addressed now. If there's anything else, please open separate issues for each problem. |
I think it might be, I'd love @richtabor's input as he was a big part of pushing for the initial setup. Thank you for all the work! |
@ryelle this may already be fixed but not deployed, but just making sure to capture it, this title should also just say "Patterns", not "Block Pattern Directory": |
Nope, that's set elsewhere, so it was missed. This issue is closed though, can you drop that into a new issue? |
Catching up here, but yes a row of categories is good. |
This explores the block theme conversion. Looks really good, you can take the bits of feedback here that make the most sense, and if anything requires more conversation, can skip that.
Small things:
To consider:
Individual pattern permalinks
Can use a smaller corner radius:
Some designs
Outline and solid stars for favorite and favorited:
Footer:
To consider, depending on how much we want to do, can do at any time.
This entire footer can also be ignored for now, and be re-thought separately.
Favorites/My Patterns
New pattern
There’s a brief flash of unstyled text before the editor loads. Can we hide that, perhaps even show a spinner?
Probably a followup, but there are some designs for how to potentially improve the create pattern flow here.
The text was updated successfully, but these errors were encountered: