Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block Theme: A quick design review / Design QA #633

Closed
jasmussen opened this issue Mar 7, 2024 · 5 comments
Closed

Block Theme: A quick design review / Design QA #633

jasmussen opened this issue Mar 7, 2024 · 5 comments

Comments

@jasmussen
Copy link

This explores the block theme conversion. Looks really good, you can take the bits of feedback here that make the most sense, and if anything requires more conversation, can skip that.

Small things:

  • Block Pattern Directory → Patterns
  • “Search patterns” instead of “Search patterns…”
  • Copy pattern could have a min-width so it doesn’t change size when it turns to “Copied pattern”. May even consider changing it to “Copied!” instead of “Copied pattern”.

To consider:

  • Rephrase the tagline. Maybe: “Copy and paste ready-to-go layouts into any WordPress site.”
  • Use the pattern bar from here instead of the new dropdown categories.

Individual pattern permalinks

  • EB Garamond headings

Can use a smaller corner radius:

corner-radius

Some designs

Outline and solid stars for favorite and favorited:

stars

Footer:

footer

To consider, depending on how much we want to do, can do at any time.

  • “Learn more” instead of the more verbose sentence.
  • Secondary outline buttons for both, don’t need the “Create” to have that white emphasis. There’s also a “New pattern” in the header.
  • Consider reducing the two paragraphs both, there’s a lot of text.
  • Either find an editorial way to have the same amount of lines (e.g. 3 lines of text), or consider applying a min-height to the paragraphs so the buttons line up.

This entire footer can also be ignored for now, and be re-thought separately.

Favorites/My Patterns

  • There’s a bit more here.
  • Use EB Garamond for the heading.
  • Can hide search.
  • The “Declined” or “Pending” chips can be overlayed, and differently colored, like this from here:

pending

New pattern

There’s a brief flash of unstyled text before the editor loads. Can we hide that, perhaps even show a spinner?

Probably a followup, but there are some designs for how to potentially improve the create pattern flow here.

ryelle added a commit that referenced this issue Mar 7, 2024
- Update search placeholder
- Update single pattern header font
- Add a min-width to the copy button
- Use filled/empty stars for favorites
- Use a smaller border radius for pattern preview
- Update footer

Fixes #633
ryelle added a commit that referenced this issue Mar 7, 2024
@ryelle
Copy link
Contributor

ryelle commented Mar 7, 2024

I've addressed most of this in the PR, so I'm going to close the issue.

Rephrase the tagline. Maybe: “Copy and paste ready-to-go layouts into any WordPress site.”

Leaving this out for now since it's not a final decision— if we want to do a full copy review, that can happen any time.

Use the pattern bar from here instead of the new dropdown categories.

This is phrased as a suggestion here, but since this would require a bit more custom code, I'd like to figure out if it's a hard requirement before spending the time.

Either find an editorial way to have the same amount of lines (e.g. 3 lines of text), or consider applying a min-height to the paragraphs so the buttons line up.

Since the container is flexible, a min-height would cause other issues— if we did a 5-line min-height it would look really strange when both containers are 4 lines (at 1600 wide). You could try working with marketing to get 3 lines of text at some size, but the container will still be responsive.

New pattern

The pattern creator is separate from the theme, but I do have a follow-up PR ready to go that will fix this once the theme is merged.

Everything else should be addressed now. If there's anything else, please open separate issues for each problem.

@ryelle ryelle closed this as completed Mar 7, 2024
@jasmussen
Copy link
Author

This is phrased as a suggestion here, but since this would require a bit more custom code, I'd like to figure out if it's a hard requirement before spending the time.

I think it might be, I'd love @richtabor's input as he was a big part of pushing for the initial setup.

Thank you for all the work!

@jasmussen
Copy link
Author

@ryelle this may already be fixed but not deployed, but just making sure to capture it, this title should also just say "Patterns", not "Block Pattern Directory":

Screenshot 2024-03-14 at 10 43 23

@ryelle
Copy link
Contributor

ryelle commented Mar 18, 2024

Nope, that's set elsewhere, so it was missed. This issue is closed though, can you drop that into a new issue?

@richtabor
Copy link
Member

Use the pattern bar from here instead of the new dropdown categories.

This is phrased as a suggestion here, but since this would require a bit more custom code, I'd like to figure out if it's a hard requirement before spending the time.

I think it might be, I'd love @richtabor's input as he was a big part of pushing for the initial setup.

Catching up here, but yes a row of categories is good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants