Support changing autoload value for largest autoloaded options in Site Health check

[mukeshpanchal27]

Summary

Fixes #889

Checklist

• PR has either [Focus] or Infrastructure label.
• PR has a [Type] label.
• PR has a milestone or the no milestone label.

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: mukeshpanchal27 <mukesh27@git.wordpress.org>
Co-authored-by: westonruter <westonruter@git.wordpress.org>
Co-authored-by: felixarntz <flixos90@git.wordpress.org>
Co-authored-by: swissspidy <swissspidy@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[mukeshpanchal27]

@westonruter, I have addressed the review feedback. The PR is ready for another round of review. Thank you!

[felixarntz]

@mukeshpanchal27 I don't have much to add to the existing feedback. Most importantly from my perspective though, we either need to do the AJAX + JS approach the right way, or alternatively go with the much simpler alternative of using a page reload and a regular WP Admin callback via "action URL".

[mukeshpanchal27]

Thanks, @felixarntz, @westonruter, and @swissspidy for the feedback. Per the discussion in #1048 (comment), I also believe that the action URL approach is the right choice. Additionally, I've added an admin notice when the option is updated.

[felixarntz]

@mukeshpanchal27 This looks very close now. I only have one broader suggestion on how to handle the option size to display to the user more dynamically.

[mukeshpanchal27]

Thank you, @felixarntz and @westonruter, for your feedback. The PR is now ready for the final review and merge.

[felixarntz]

@mukeshpanchal27 Two small last things, otherwise this is good to go IMO. Great stuff!

[westonruter]

Will there be tests added for this?

[swissspidy]

Will there be tests added for this?

This would be a good candidate for an e2e test. Makes me wonder why we don't have any 🤔

[mukeshpanchal27]

Will there be tests added for this?

This would be a good candidate for an e2e test. Makes me wonder why we don't have any 🤔

We don't currently have e2e tests set up in the PL repository. I'm exploring how we can add tests for these changes. 😅

[swissspidy]

I saw that, hence the wondering why :)

here, some php unit tests should be possible

[mukeshpanchal27]

@swissspidy @westonruter I've added unit tests. It appears that the unit tests are failing in WP 6.3 due to the introduction of wp_set_option_autoload in 6.4. We'll need to update the workflow accordingly.

[swissspidy]

I thought #1062 updated the workflows? Why are we still testing 6.3? Let's just fix that here.

[felixarntz]

@mukeshpanchal27 @swissspidy Strange that this is not failing in trunk 🤔

But anyway, great to fix here.

[felixarntz]

@westonruter Which kinds of tests are you envisioning? In terms of PHPUnit, maybe a test of the "action function" to update the autoload values would be useful. I'm not sure it's worth adding tests for the Site Health UI bits as that's relatively trivial and IMO more difficult to test than it provides value.