Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for AVIF image in site health #1177

Conversation

itzmekhokan
Copy link
Contributor

Summary

Fixes #1152

Relevant technical choices

Adds a module in site health to check for AVIF image format is support and shows a warning if support is not present.
If server has AVIF support, the AVIF support warning is not shown.

Screenshot

Screenshot 2024-04-24 at 8 57 38 PM

Copy link

github-actions bot commented Apr 24, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: itzmekhokan <khokansardar@git.wordpress.org>
Co-authored-by: mukeshpanchal27 <mukesh27@git.wordpress.org>
Co-authored-by: westonruter <westonruter@git.wordpress.org>
Co-authored-by: adamsilverstein <adamsilverstein@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Member

@westonruter westonruter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@westonruter westonruter added this to the performance-lab 3.1.0 milestone Apr 24, 2024
@westonruter westonruter added [Type] Enhancement A suggestion for improvement of an existing feature [Plugin] Performance Lab Issue relates to work in the Performance Lab Plugin only labels Apr 24, 2024
Copy link
Member

@mukeshpanchal27 mukeshpanchal27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @itzmekhokan for the PR! Left some nit-pick.

includes/site-health/avif-support/helper.php Outdated Show resolved Hide resolved
includes/site-health/avif-support/helper.php Outdated Show resolved Hide resolved
includes/site-health/avif-support/hooks.php Outdated Show resolved Hide resolved
includes/site-health/avif-support/hooks.php Outdated Show resolved Hide resolved
@mukeshpanchal27 mukeshpanchal27 merged commit ff4dcde into WordPress:trunk Apr 25, 2024
14 checks passed
@itzmekhokan
Copy link
Contributor Author

Thanks @itzmekhokan for the PR! Left some nit-pick.

@mukeshpanchal27 Updated the points.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Plugin] Performance Lab Issue relates to work in the Performance Lab Plugin only [Type] Enhancement A suggestion for improvement of an existing feature
Projects
Status: Done 😃
Development

Successfully merging this pull request may close these issues.

Add AVIF support information under Site Health status tab
3 participants