Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-remove unneeded phpcs:ignore #1231

Merged
merged 2 commits into from
May 21, 2024
Merged

Re-remove unneeded phpcs:ignore #1231

merged 2 commits into from
May 21, 2024

Conversation

westonruter
Copy link
Member

Re-applies 1c27166 which was somehow undone.

With this, there are no other instances of phpcs:ignore WordPress.PHP.NoSilencedErrors.Discouraged in the codebase.

Fixes #709

Re-applies 1c27166 which was somehow undone.

Co-authored-by: pbearne <pbearne@git.wordpress.org>
@westonruter westonruter added [Type] Bug An existing feature is broken skip changelog PRs that should not be mentioned in changelogs labels May 20, 2024
Copy link

github-actions bot commented May 20, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: westonruter <westonruter@git.wordpress.org>
Co-authored-by: aristath <aristath@git.wordpress.org>
Co-authored-by: mukeshpanchal27 <mukesh27@git.wordpress.org>
Co-authored-by: swissspidy <swissspidy@git.wordpress.org>
Co-authored-by: felixarntz <flixos90@git.wordpress.org>
Co-authored-by: joemcgill <joemcgill@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@swissspidy swissspidy merged commit be4c00a into trunk May 21, 2024
22 checks passed
@swissspidy swissspidy deleted the remove/no-silenced-errors branch May 21, 2024 09:38
@westonruter westonruter removed the skip changelog PRs that should not be mentioned in changelogs label Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug An existing feature is broken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the @ silencing warnings from PL
4 participants