Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve message for WebP site health test #1249

Merged
merged 6 commits into from
Jun 12, 2024

Conversation

the-hercules
Copy link
Contributor

@the-hercules the-hercules commented May 26, 2024

Fixes #715

Summary

Updated error message in the WordPress performance plugin regarding WebP image support. The message now informs users that WebP images require support from the web server's image processing libraries (Imagick or LibGD) and provides guidance on checking supported file formats.

@the-hercules
Copy link
Contributor Author

@thelovekesh Some checks are failing due to missing labels, can you add labels to this PR?

@mukeshpanchal27 mukeshpanchal27 added [Plugin] Modern Image Formats Issues for the Modern Image Formats plugin (formerly WebP Uploads) no milestone PRs that do not have a defined milestone for release [Type] Enhancement A suggestion for improvement of an existing feature labels May 27, 2024
@the-hercules the-hercules marked this pull request as ready for review May 27, 2024 06:19
Copy link

github-actions bot commented May 27, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @hercules@herculess-MacBook-Air.local, @aashish.sharma@rtcamp.com.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Unlinked contributors: hercules@herculess-MacBook-Air.local, aashish.sharma@rtcamp.com.

Co-authored-by: the-hercules <thehercules@git.wordpress.org>
Co-authored-by: mukeshpanchal27 <mukesh27@git.wordpress.org>
Co-authored-by: joemcgill <joemcgill@git.wordpress.org>
Co-authored-by: westonruter <westonruter@git.wordpress.org>
Co-authored-by: adamsilverstein <adamsilverstein@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Member

@mukeshpanchal27 mukeshpanchal27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. The link should be clickable.

Screenshot 2024-05-27 at 12 55 45 PM

@westonruter westonruter removed the no milestone PRs that do not have a defined milestone for release label May 28, 2024
@westonruter westonruter added [Plugin] Performance Lab Issue relates to work in the Performance Lab Plugin only and removed [Plugin] Modern Image Formats Issues for the Modern Image Formats plugin (formerly WebP Uploads) labels May 28, 2024
Copy link
Member

@joemcgill joemcgill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prior to merging these changes, I think we need to consider whether the updated text addresses the issue. See #715 (comment).

@westonruter
Copy link
Member

@the-hercules new suggested text from @adamsilverstein in #715 (comment)

@the-hercules
Copy link
Contributor Author

@westonruter does this message looks good ?

WebP support can only be enabled by your hosting provider. Please contact them to inquire about switching to a plan that supports WebP, or consider switching to a host that offers this feature. For more information about WebP image support for WordPress sites, please Learn more here.

@westonruter
Copy link
Member

For more information about WebP image support for WordPress sites, please Learn more here.

I would phrase this rather as:

Learn more about WebP image support for WordPress sites.

I'll defer to @adamsilverstein for the ultimate wording.

@adamsilverstein
Copy link
Member

Looks good, including suggestion from @westonruter

Copy link
Member

@westonruter westonruter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with a possible improved word choice.

@westonruter westonruter changed the title fix: Update WebP not Supported message Improve message for WebP site health test Jun 7, 2024
@the-hercules
Copy link
Contributor Author

@mukeshpanchal27 @joemcgill Awaiting Review, I have made the suggested Changes.

@the-hercules
Copy link
Contributor Author

Hey @joemcgill , Could you please review this PR.

@westonruter westonruter merged commit 31c6ee9 into WordPress:trunk Jun 12, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Plugin] Performance Lab Issue relates to work in the Performance Lab Plugin only [Type] Enhancement A suggestion for improvement of an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance the health check message when WebP is not supported
5 participants