-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only store info for relevant standalone plugins in the transient cache #1573
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mukeshpanchal27 Great catch!
PR looks good, though one recommendation to improve performance.
FYI: We forgot to account for plugin dependencies here. Follow-up PR: #1613 |
Follow-up on #1562
The current API query
https://api.wordpress.org/plugins/info/1.2/?action=query_plugins&request[author]=wordpressdotorg&request[tag]=performance&request[per_page]=100
is returning some unrelated plugins likePlugin Check (PCP)
andSQLite Database Integration
. In the future, if anyone else usesPerformance
as a tag, it will also be added to ourtransient
. However, we only need the standalone plugins defined inperflab_get_standalone_plugin_data()
.I’ve also moved the array definition for
$fields
after the cache check, as it's redundant in the cached version.