Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Site Health reports copy #269

Closed
wants to merge 2 commits into from

Conversation

mxbclang
Copy link
Contributor

Summary

Fixes #229.

Checklist

  • PR has either [Focus] or Infrastructure label.
  • PR has a [Type] label.
  • PR has a milestone or the no milestone label.

@mxbclang mxbclang added [Focus] Site Health no milestone PRs that do not have a defined milestone for release labels Mar 28, 2022
@mxbclang mxbclang requested a review from audrasjb as a code owner March 28, 2022 13:31
@mxbclang mxbclang self-assigned this Mar 28, 2022
@mxbclang mxbclang changed the title Update autoloaded options copy Update Site Health reports copy Mar 28, 2022
@mxbclang mxbclang added the [Type] Enhancement A suggestion for improvement of an existing feature label Mar 28, 2022
@mxbclang mxbclang marked this pull request as draft March 28, 2022 14:29
Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bethanylang Left two comments, mostly this looks good so far.

Would you like to incorporate your suggestions on the WebP Support and Object Cache checks from #229 (comment) into this PR as well? I'd say that would work, and this way it could all be reviewed together. I agree the Enqueued Assets bit should remain separate as it needs more higher-level discussion.

@mxbclang
Copy link
Contributor Author

Requesting to close as I've updated the branch name and submitted a new PR: #272. Sorry for the trouble!

@mxbclang mxbclang closed this Mar 29, 2022
@mxbclang mxbclang deleted the update-autoloaded-options-copy branch March 29, 2022 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no milestone PRs that do not have a defined milestone for release [Type] Enhancement A suggestion for improvement of an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Standardize structure for Site Health reports
2 participants