Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance experience when installing and activating a standalone plugin #900

Merged
merged 13 commits into from
Dec 18, 2023
Merged

Enhance experience when installing and activating a standalone plugin #900

merged 13 commits into from
Dec 18, 2023

Conversation

mukeshpanchal27
Copy link
Member

Summary

Fixes #880

Checklist

  • PR has either [Focus] or Infrastructure label.
  • PR has a [Type] label.
  • PR has a milestone or the no milestone label.

@mukeshpanchal27 mukeshpanchal27 added [Type] Enhancement A suggestion for improvement of an existing feature Infrastructure Issues for the overall performance plugin infrastructure no milestone PRs that do not have a defined milestone for release Creating standalone plugins labels Dec 12, 2023
@mukeshpanchal27 mukeshpanchal27 self-assigned this Dec 12, 2023
@mukeshpanchal27 mukeshpanchal27 marked this pull request as ready for review December 12, 2023 09:53
swissspidy
swissspidy reviewed Dec 12, 2023
View reviewed changes
felixarntz
felixarntz requested changes Dec 12, 2023
View reviewed changes
Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mukeshpanchal27, it's great you found a solution for this problem. I left a bit of feedback below, but the overall approach looks solid.

westonruter
westonruter reviewed Dec 12, 2023
View reviewed changes
felixarntz
felixarntz reviewed Dec 13, 2023
View reviewed changes
westonruter
westonruter reviewed Dec 13, 2023
View reviewed changes
mukeshpanchal27 and others added 2 commits December 14, 2023 10:02
@mukeshpanchal27 @felixarntz
Apply suggestions from code review
01a2f21 
Co-authored-by: Felix Arntz <felixarntz@users.noreply.github.com>
@mukeshpanchal27
Address review feedback
72c49c1
@mukeshpanchal27
Copy link
Member Author

Thank you, @felixarntz, @swissspidy, and @westonruter, for your feedback. I have addressed it, and the PR is now ready for review.

westonruter
westonruter reviewed Dec 14, 2023
View reviewed changes
westonruter
westonruter reviewed Dec 14, 2023
View reviewed changes
westonruter
westonruter reviewed Dec 14, 2023
View reviewed changes
westonruter
westonruter reviewed Dec 14, 2023
View reviewed changes
felixarntz
felixarntz reviewed Dec 14, 2023
View reviewed changes
mukeshpanchal27 and others added 4 commits December 15, 2023 10:24
@mukeshpanchal27 @felixarntz @westonruter
Apply suggestions from code review
23e8d3d 
Co-authored-by: Felix Arntz <felixarntz@users.noreply.github.com>
Co-authored-by: Weston Ruter <westonruter@google.com>
@mukeshpanchal27
Address review feedback
3efd1ed
@mukeshpanchal27
Address review feedback
f884e85
@mukeshpanchal27
Fix multiple installation bug
b936064
@mukeshpanchal27
Copy link
Member Author

@felixarntz @westonruter, I identified an edge case while installing multiple plugins and try to activate first plugin where we encountered an incorrect selector in event.target.activeElement. Consequently, In b936064 i have updated the selector in the logic, and the issue has been resolved. Could you please review it? Thank you.

felixarntz
felixarntz approved these changes Dec 15, 2023
View reviewed changes
Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @mukeshpanchal27!

Only one minor thing that would be good to address, but not a blocker.

westonruter
westonruter previously requested changes Dec 15, 2023
View reviewed changes
mukeshpanchal27 and others added 3 commits December 18, 2023 11:23
@mukeshpanchal27 @felixarntz
Apply suggestions from code review
ddfc72b 
Co-authored-by: Felix Arntz <felixarntz@users.noreply.github.com>
@mukeshpanchal27 @westonruter
Apply suggestions from code review
ac00153 
Co-authored-by: Weston Ruter <westonruter@google.com>
@mukeshpanchal27
Remove template literal, Fix PHPStan
fe313c7
@mukeshpanchal27
Copy link
Member Author

@swissspidy Could you kindly take a moment to review the recent changes?

@swissspidy swissspidy merged commit d717f68 into feature/creating-standalone-plugins Dec 18, 2023
7 checks passed
@swissspidy swissspidy deleted the fix/880 branch December 18, 2023 12:26
@mukeshpanchal27 mukeshpanchal27 mentioned this pull request Dec 18, 2023
Closed
@mukeshpanchal27 mukeshpanchal27 mentioned this pull request Jan 5, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@westonruter westonruter westonruter left review comments

@swissspidy swissspidy swissspidy approved these changes

@felixarntz felixarntz felixarntz approved these changes

@joemcgill joemcgill Awaiting requested review from joemcgill

@10upsimon 10upsimon Awaiting requested review from 10upsimon

@JustinyAhin JustinyAhin Awaiting requested review from JustinyAhin

Assignees

@mukeshpanchal27 mukeshpanchal27

Labels
Infrastructure Issues for the overall performance plugin infrastructure no milestone PRs that do not have a defined milestone for release [Type] Enhancement A suggestion for improvement of an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mukeshpanchal27 @westonruter @swissspidy @felixarntz