Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Playground Block broken in Safari #176

Closed
adamziel opened this issue Mar 5, 2024 · 1 comment
Closed

Playground Block broken in Safari #176

adamziel opened this issue Mar 5, 2024 · 1 comment
Labels
Blocker Bug Something isn't working Playground block
Milestone
Zero Crashes – Tools

Comments

@adamziel
Copy link
Collaborator

adamziel commented Mar 5, 2024

Running the Playground Block in Safari results in the following error:

[Error] Unhandled Promise Rejection: TypeError: ReadableByteStreamController is not implemented

CleanShot 2024-03-05 at 19 01 21@2x

Reproduction link: https://playground.wordpress.net/?plugin=interactive-code-block&blueprint-url=https://wordpress.org/plugins/wp-json/plugins/v1/plugin/interactive-code-block/blueprint.json?rev=3045844
@adamziel adamziel added Bug Something isn't working Playground block Blocker labels Mar 5, 2024
@adamziel adamziel added this to the Zero Crashes – Tools milestone Mar 5, 2024
@adamziel adamziel mentioned this issue Mar 5, 2024
Merged
adamziel added a commit that referenced this issue Mar 6, 2024
@adamziel
Update Blueprints to 0.6.7
86632e0 
This PR Updates the `@wp-playground/blueprints` dependency to a newer
version and removes the dependency on `@wp-playground/client`. This
fixes the Playground block in safari:

#176

 ## Testing instructions

Confirm the CI checks are green
@adamziel adamziel mentioned this issue Mar 6, 2024
Merged
adamziel added a commit that referenced this issue Mar 6, 2024
@adamziel
Update Blueprints to 0.6.7
7815b97 
This PR Updates the `@wp-playground/blueprints` dependency to a newer
version and removes the dependency on `@wp-playground/client`. This
fixes the Playground block in safari:

#176

 ## Testing instructions

Confirm the CI checks are green
@adamziel adamziel moved this to In progress in Playground Board Mar 6, 2024
adamziel added a commit that referenced this issue Mar 6, 2024
@adamziel
Playground Block: Remove @wp-playground/client and @wp-playground/blu…
7871b82 
…eprints dependency (#179)

This PR Updates makes the WordPress Playground Block rely on the client
library imported from https://playground.wordpress.net/client/index.js.
This fixes the Playground block in safari:

#176

 ## Testing instructions

Confirm the CI checks are green
@adamziel
Copy link
Collaborator Author

adamziel commented Mar 6, 2024

Fixed in WordPress/wordpress-playground#1089

@adamziel adamziel closed this as completed Mar 6, 2024
@github-project-automation github-project-automation bot moved this from In progress to Done in Playground Board Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Blocker Bug Something isn't working Playground block
Projects
Playground Board
Archived in project
Milestone
Zero Crashes – Tools
Development

No branches or pull requests
1 participant
@adamziel