Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wp-now: Restore node 18 support #87

Closed
danielbachhuber opened this issue Jul 6, 2023 · 5 comments · Fixed by #90
Closed

wp-now: Restore node 18 support #87

danielbachhuber opened this issue Jul 6, 2023 · 5 comments · Fixed by #90
Assignees
Labels

Comments

@danielbachhuber
Copy link
Member

Minimum supported version was bumped to node 20 in #82 (comment) but we should keep node 18 support for now.

Done is:

  • Minimum supported version is 18.
  • For any node 20 feature, we throw a warning (or error) if the current version is node 18.
@danielbachhuber
Copy link
Member Author

@sejas Just wanted to let you know that @dmsnell worked through this and put together #90.

As it turns out, wp-now start still works fine on Node 18. wp-now start --blueprint=blueprint.json will crash, but that's documented now in the README. I think this is a fine place for now.

@sejas
Copy link
Collaborator

sejas commented Jul 19, 2023

@danielbachhuber , @dmsnell, thank you for the change.

danielbachhuber pushed a commit that referenced this issue Jul 19, 2023
<!-- Thanks for contributing to WordPress Playground Tools! -->

## What?

<!-- In a few words, what is the PR actually doing? Include screenshots
or screencasts if applicable -->

- For consistency with
#90
- Related to #87

Set the nvm node version to v18.
@dmsnell
Copy link
Member

dmsnell commented Jul 19, 2023

Thanks @sejas!

@amplify11dev
Copy link

@sejas Just wanted to let you know that @dmsnell worked through this and put together #90.

As it turns out, wp-now start still works fine on Node 18. wp-now start --blueprint=blueprint.json will crash, but that's documented now in the README. I think this is a fine place for now.

Where in the README does it call out it will crash in 18? I could be looking at the wrong repo/readme but I ran into this exact issue and didn't see it documented anywhere.

@danielbachhuber
Copy link
Member Author

@amplify11dev It's mentioned in "Getting Started":

CleanShot 2023-08-28 at 03 58 19@2x

We could probably include a mention in the argument documentation too. Want to submit a PR for that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants