-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Playground dependencies in package.json #139
Conversation
@@ -50,19 +50,6 @@ export default async function startWPNow( | |||
requestHandler: { | |||
documentRoot, | |||
absoluteUrl: options.absoluteUrl, | |||
isStaticFilePath: (path) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is now handled by Playground core.
Awesome! Thanks for creating the PR 🙏 . - v18.13.0
+ v18.18.2 When trying to install the dependencies I got this error:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested it locally and it works great.
- I think we can follow Github's recommendation to delete
seemsLikeAPHPFile
function. - Let's update
.nvmrc
to use the same@php-wasm/node
node version requirement:v18.18.2
.
Testing steps:
- Update
.nvmrc
to usev18.18.2
- Run:
nvm use
npm install
npx nx build wp-now
node dist/packages/wp-now/cli.js start
- Observe
wp-now
successfully started.
Awesome, thank you so much @sejas! Let's ship! 🚢 🚢 🚢 |
What?
Updates the versions of WordPress Playground packages and makes the necessary adjustments to make the tests work with these new version. WordPress Playground
0.5.4
is compatible with Node.js v18 via polyfills, which means wp-now will now be able to use Blueprint steps likeinstallPlugin
.Testing Instructions
Confirm the CI checks pass
cc @sejas @danielbachhuber @wojtekn