-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update wp-now documentation #251
Conversation
## What is this PR doing? 1. Reorganizing the **Contributing** chapter of the docs, and updating the content. See [this issue](adamziel/playground-docs-workflow#31 (comment)) 2. Adding references to [the Developer docs](https://developer.wordpress.org/) in relevant Blueprints steps. See #1291. ~### To-Do:~ - [x] Update [wp-now](https://www.npmjs.com/package/@wp-now/wp-now) README. **Done** in [Update wp-now documentation #251](WordPress/playground-tools#251). ## Testing Instructions 1. Build the site (standard `npm run build` to update the steps in `packages/playground/blueprints/src/lib/steps/`) 2. Run `npm run dev:docs`. 3. Review the changes. @adamziel
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
made some suggestions, let's continue the discussion! The main point is (personally) - I think the page should probably be broken out into multiple pages
Nice changes for readability and functionality so far!
Thanks, @flexseth! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good. Thanks @ironnysh!!
As more changes come to the wp-now
interface, the docs will most likely mature in time. Going to try to track changes and keep a log of docs pages that can be updated as new features and modifications come online. Thanks again for taking a look!!
Cheers, @flexseth, and thanks for the review.
Sure, just important to remember the distinction between the docs and the README 😄 especially while the current setup (Docusaurus) remains.
Not sure if it covers both repos ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautiful! Thanks for your hard work @ironnysh 🙏 |
What?
Updating the
wp-now
README file.Why?
Some information was outdated or missing.
See details in this issue.
Testing Instructions
Review the text :-)