Playground block: Add ARIA labels to icon-only buttons #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonpayton
force-pushed
the
pg-block-label-icon-buttons
branch
from
66c8b02 to
9d73c96
Compare
brandonpayton
changed the title
|
I'm going to merge this because it has been tested and is low risk. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR adds ARIA labels to the code editor's "Add File" and "Download Code as a Zip File" buttons which previously only included visual indications of their function.
Fixes #286
Why?
Without ARIA labels, people using assistive technology may have no way to know what the buttons do.
Testing Instructions
npx nx run wordpress-playground-block:dev