Networking: Swap Requests transports using the http_api_transports instead of patching the Requests library #1004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stead of patching the Requests library. Before this PR, we were patching the default WordPress transports to always return `false` from their `test()` method which, otherwise, could return a false positive. It was a hack. It solved the problem at hand, but added complexity and maintenance burden. This PR removes the patching and instead swaps the Requests transports from within the Playground my-plugin using the `http_api_transports` WordPress filter. ## Testing instructions Confirm the CI checks pass cc @bgrgicak
adamziel
added
[Type] Enhancement
adamziel
added a commit
that referenced
this pull request
Feb 6, 2024
Installs the Playground mu-plugin even when WordPress is loaded from the OPFS to ensure: * The mu-plugin is always there, even when a custom WordPress directory is mounted. * The mu-plugin is always up to date. Depends on #1004 ## Testing instructions Confirm the CI checks pass
adamziel
added a commit
that referenced
this pull request
Feb 22, 2024
The recent [removal of custom WordPress patches](#1004) broke the networking feature when the extra PHP extensions are enabled. It removed the default networking tranports via the http_api_transports filter, but it did not account for WordPress trying to use the Fetch and Fsockopen transports anyway whenever their `::test()` method returns true – which it does when the OpenSSL extension is available. This PR uses the reflections API to force-replace the Requests::$transports array with one containing exclusively the Fetch transport. Open Playground, enable PHP extensions and networking, go to WP Admin > Plugins > Add, confirm the list of plugins is visible CC @bgrgicak @annezazu
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, we were patching the default WordPress transports to always return
falsefrom theirtest()method which, otherwise, could return a false positive. It was a hack. It solved the problem at hand, but added complexity and maintenance burden.This PR removes the patching and instead swaps the Requests transports from within the Playground my-plugin using the
http_api_transportsWordPress filter.Testing instructions
Confirm the CI checks pass
cc @bgrgicak