Fix: Networking broken when extra PHP extensions are enabled #1045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The recent [removal of custom WordPress patches](#1004) broke the networking feature when the extra PHP extensions are enabled. It removed the default networking tranports via the http_api_transports filter, but it did not account for WordPress trying to use the Fetch and Fsockopen transports anyway whenever their `::test()` method returns true – which it does when the OpenSSL extension is available. This PR uses the reflections API to force-replace the Requests::$transports array with one containing exclusively the Fetch transport. Open Playground, enable PHP extensions and networking, go to WP Admin > Plugins > Add, confirm the list of plugins is visible CC @bgrgicak @annezazu
adamziel
added
[Type] Bug
bgrgicak
approved these changes
Feb 23, 2024
There was a problem hiding this comment.
Works as described.
I took the time to start a Wiki with Blueprint examples and added this as the first one.
Here is a local link for testing this PR http://localhost:5400/website-server/?blueprint-url=https://gist.githubusercontent.com/bgrgicak/0784d4d67d0b57657957c9d7c85cdea0/raw/blueprint.json
adamziel
deleted the
fix-networking-when-the-kitchen-sink-bundle-is-enabled
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent removal of custom WordPress
patches broke the networking feature when the extra PHP extensions are enabled. It removed the default networking tranports via the http_api_transports filter, but it did not account for WordPress trying to use the Fetch and Fsockopen transports anyway whenever their
::test()method returns true – which it does when the OpenSSL extension is available.This PR uses the reflections API to force-replace the Requests::$transports array with one containing exclusively the Fetch transport.
Open Playground, enable PHP extensions and networking, go to WP Admin > Plugins > Add, confirm the list of plugins is visible
CC @bgrgicak @annezazu