Ensure PromiseRejectionEvent has reason before logging it #1150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgrgicak
added
[Type] Bug
adamziel
reviewed
Mar 28, 2024
| @@ -76,7 +76,12 @@ export class Logger extends EventTarget { | |||
| * @param PromiseRejectionEvent event | |||
| */ | |||
| private logUnhandledRejection(event: PromiseRejectionEvent) { | |||
| this.log(`${event.reason.stack}`, 'Error'); | |||
| // No reason was provided, so we can't log anything. | |||
There was a problem hiding this comment.
Should this confirm the reason is not PHP fatal error but WASM crash? Or no need?
There was a problem hiding this comment.
Yes, that's a great point! I will take some extra time to test it with the memory leak example and see if we can get some insights from the error.
There was a problem hiding this comment.
I couldn't get any extra info here, so I will merge this PR as is.
adamziel
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1149
What is this PR doing?
Checks if
event.reasonorevent.reason.stackexist inlogUnhandledRejection.What problem is it solving?
Fixes a JS error when a promise without a reason is thrown.
How is the problem addressed?
By checking if a reason is provided.
Testing Instructions
npm run dev