Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure PromiseRejectionEvent has reason before logging it #1150

Merged
merged 2 commits into from
Mar 29, 2024
Merged

Ensure PromiseRejectionEvent has reason before logging it #1150

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8e3cf0a
Ensure PromiseRejectionEvent has reason before logging it
bgrgicak Mar 28, 2024
b4a8ce2
Merge branch 'trunk' into fix/1149-promise-reject-without-reason
bgrgicak Mar 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion packages/php-wasm/logger/src/lib/logger.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,12 @@ export class Logger extends EventTarget {
* @param PromiseRejectionEvent event
*/
private logUnhandledRejection(event: PromiseRejectionEvent) {
this.log(`${event.reason.stack}`, 'Error');
// No reason was provided, so we can't log anything.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this confirm the reason is not PHP fatal error but WASM crash? Or no need?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's a great point! I will take some extra time to test it with the memory leak example and see if we can get some insights from the error.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't get any extra info here, so I will merge this PR as is.

if (!event?.reason) {
return;
}
const message = event?.reason.stack ?? event.reason;
this.log(message, 'Error');
}

/**
Expand Down
Loading