-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try: A simple photoblogging theme #120
Conversation
@@ -0,0 +1,11 @@ | |||
<!-- wp:spacer {"height":38} --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a lot of blocks with this exact setting - could we make it a reusable block, or a block style?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm that's a good point! A block style might get confusing if the user were to edit it... and themes can't bundle reusable blocks today... I think the right way to do this would be to have a global styles setting for the default spacer block height. I'll open a Gutenberg issue for it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issue here: WordPress/gutenberg#27614
This looks great. It would be good to open issues for the parts that aren't working in Gutenberg yet, if you haven't already. |
Props to @MaggieCabrera for noticing this. 🙌
…theme-experiments into try/photo-block-theme
This is handled in Gutenberg via WordPress/gutenberg#27623
…theme-experiments into try/photo-block-theme
Most of the easy-to-fix Gutenberg pieces in this theme have been merged, and the rest have open issues. So I think we're probably at a good place for merging this experiment in if someone would give it one more review? |
add_theme_support( 'align-wide' ); | ||
|
||
// Adding support for core block visual styles. | ||
add_theme_support( 'wp-block-styles' ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume we need these here rather than putting them in theme.json?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now, yes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks, everyone! |
I hadn't seen a block-based example of a typical photo blog theme, so I built this to try it out. This heavily uses the Query block's new Grid view.
A few bumps I ran into:
I left a few other small notes in the code itself.
GIF