Skip to content
This repository has been archived by the owner on Nov 18, 2024. It is now read-only.

Fix wide and full width content on the default home, archive and search templates #455

Merged
merged 1 commit into from
Sep 28, 2024

Conversation

carolinan
Copy link
Contributor

@carolinan carolinan commented Sep 28, 2024

Description
At some point a regression has happened that cases the full width patterns to only display at content width on the default
home, archive and search templates.

This PR tries to make sure that full and wide content displays correctly. Please see the before and after screenshots.

Closes #428

Screenshots
Please excuse that these images are not taken on the same computer and screen width.

Before:

home-width

width-test

After:
67 local_

Testing Instructions

Create one or more posts with default, wide and full width content.

There are a couple things to make sure here:

  1. The design matches Figma: https://www.figma.com/design/dzGCSntVch4EQdVERTqyVK/Twenty-Twenty-Five?node-id=559-1862&t=s3gLMzojsInRTy1N-4
  2. The "Blog" heading aligns with the featured image, post title and default content width.
  3. Post content that is set to wide align, aligns with header, footer and query pagination.
  4. Post content that is set to full width is full width, edge to edge of the browser.
  5. The featured image and post title do not touch the edge of the browser on small screen widths. -Confirm that this issue is not happening again: Default blog, archive and search templates: Featured image and title bump screen's edges #345

@carolinan carolinan added the [Type] Bug An existing feature does not function as intended. label Sep 28, 2024
Copy link

Preview changes

You can preview these changes by following the link below:

I will update this comment with the latest preview links as you push more changes to this PR.
⚠️ Note: The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

@carolinan carolinan requested a review from jasmussen September 28, 2024 08:49
Copy link

github-actions bot commented Sep 28, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: carolinan <poena@git.wordpress.org>
Co-authored-by: juanfra <juanfra@git.wordpress.org>
Co-authored-by: jasmussen <joen@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@carolinan carolinan added the [Priority] High Used to indicate top priority items that need quick attention label Sep 28, 2024
Copy link
Member

@juanfra juanfra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, looks good to me.

Screen.Recording.2024-09-28.at.10.04.25.mov

@carolinan
Copy link
Contributor Author

Thank you for the review.

The right-aligned blog may be trickier. 😬

@carolinan carolinan merged commit 7a5e3c5 into trunk Sep 28, 2024
6 checks passed
@juanfra juanfra deleted the update/default-template-widths branch September 28, 2024 09:12
@jasmussen
Copy link
Contributor

Thank you for fixing this one!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
[Priority] High Used to indicate top priority items that need quick attention [Type] Bug An existing feature does not function as intended.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Posts on the default home template are displayed at content width instead of wide width
3 participants