Skip to content
This repository has been archived by the owner on Jan 24, 2024. It is now read-only.

Make the default home page a pattern so it can be switched back to #486

Merged
merged 3 commits into from
Sep 25, 2023

Conversation

scruffian
Copy link
Contributor

Description

If we land WordPress/gutenberg#54609, we need a way for users to preview the original home template.

Screenshots

Screenshot 2023-09-22 at 10 38 42

Testing Instructions

  1. Checkout Add template replace flow to template inspector gutenberg#54609
  2. Open the "Replace template" option
  3. Confirm that you see the default template as well as the writer and portfolio ones.

Contributors

@MaggieCabrera
Copy link
Collaborator

I think you are missing files here :D

@scruffian
Copy link
Contributor Author

you're right, added!

@carolinan
Copy link
Contributor

carolinan commented Sep 22, 2023

We should do this regardless of whether the Gutenberg PR will be ready or not.
I am not convinced it is a good idea to include the feature in 6.4 since it is not complete and won't be tested in time, and I don't see a "blessing" from the release leads.

@luminuu
Copy link
Member

luminuu commented Sep 25, 2023

We can try to escalate this to the release leads if it makes sense to do so.

@MaggieCabrera
Copy link
Collaborator

We can try to escalate this to the release leads if it makes sense to do so.

Yeah, since this release is so short, I think we can push for this to actually make it. If testing during beta reveals it's not ready, we can always pull it back

@luminuu
Copy link
Member

luminuu commented Sep 25, 2023

Just noticed we have the linked issue to this PR already in our Gutenberg tracking issue, which has been blessed last week. So I hope we can get it in!

Copy link
Collaborator

@MaggieCabrera MaggieCabrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I renamed the patterns for consistency, LGTM

@MaggieCabrera MaggieCabrera merged commit 5622863 into trunk Sep 25, 2023
2 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Development

Successfully merging this pull request may close these issues.

4 participants