Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine CSS from Site Health with Privacy Settings #1266

Conversation

laras126
Copy link

@laras126 laras126 commented May 19, 2021

For declaration blocks in site-health.css that are duplicates of those for Privacy Settings in edit.css, add the selectors from site-health.css to the ruleset in edit.css to combine these duplicate styles.

There were two areas with inconsistency that I changed when moving the selectors:

  • Addition of user-select: auto to .privacy-settings-accordion-trigger
  • Use flex for alignment in .health-check-title-section vs. only text-align
  • Add padding-top: 8px to .privacy-settings-title-section to match that of Site Health

Trac ticket: https://core.trac.wordpress.org/ticket/52429


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions
Copy link

Hi @laras126! 👋

Thank you for your contribution to WordPress! 💖

It looks like this is your first pull request to wordpress-develop. Here are a few things to be aware of that may help you out!

No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description.

Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making.

More information about how GitHub pull requests can be used to contribute to WordPress can be found in this blog post.

Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook.

If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook.

The Developer Hub also documents the various coding standards that are followed:

Thank you,
The WordPress Project

@ryelle
Copy link
Contributor

ryelle commented May 20, 2021

I took a few screenshots of Site Health & Privacy (both tabs) at 3 sizes (960, 650, 400) & ran them through a diff script - mostly everything is similar, but it did highlight some differences.

✅ First in Privacy, as you mentioned, both pages are offset by 8px — I think this is a good change, it evens out the header visually.
privacy-960

✅ Privacy policy (same offset non-issue)
privacy-policy-650

⚠️ Site Health Status: The badge has a margin now when it should not, moving it over slightly
site-health-400

✅ Site Health Info: no change
site-health-info-650

⚠️ Dashboard: as mentioned on the ticket, the flex style is breaking the widget a bit
dashboard-960

@laras126
Copy link
Author

@ryelle thank you! What tool are you using to generate these diffs? Is that related to #209, or something you are doing locally?

I believe I have resolved the two problematic issues from your screenshots, and added a new selector for .health-check-widget-title-section.

@ryelle ryelle force-pushed the ticket/52429-combine-privacy-site-health-css branch from f339cb3 to 454cbd2 Compare May 26, 2021 01:22
@ryelle
Copy link
Contributor

ryelle commented May 26, 2021

Committed in r51025 🎉

@ryelle ryelle closed this May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants