Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twenty Twenty-Two: add alternate style variations #2440

Closed
wants to merge 28 commits into from

Conversation

kjellr
Copy link

@kjellr kjellr commented Mar 21, 2022

Trac ticket: https://core.trac.wordpress.org/ticket/55433

This PR adds three style variations to the Twenty Twenty-Two theme. It is dependent on the Webfonts API: #2622. If and when that is merged, this PR can be reviewed.

Testing instructions

  • Check out this PR
  • Go to the site editor and visit the global styles panel
  • Click "Browse Styles"
  • Verify all four variations load correctly

Todo:

@jffng
Copy link

jffng commented Apr 26, 2022

With the inclusion of #2622 in time for Beta 3, would it make sense and be possible to include this PR, since it leverages the feature?

I'm happy to prep the commit to trunk, but would need help on the backport to 6.0 branch I think because I don't have those privileges.

@hellofromtonya
Copy link
Contributor

With the inclusion of #2622 in time for Beta 3, would it make sense and be possible to include this PR, since it leverages the feature?

Yes, I think so. Why? The decision to include the webfonts stopgate during the beta cycle was to include TT2's new styles variations in 6.0 and for themers too.

I'm happy to prep the commit to trunk, but would need help on the backport to 6.0 branch I think because I don't have those privileges.

The 6.0-branch doesn't exist yet, i.e. not until RC1. I'll ping you once the webfonts stopgap PR is committed. Then this PR can be committed too.

@hellofromtonya
Copy link
Contributor

@jffng https://core.trac.wordpress.org/changeset/53282 committed #2622 into trunk. It's now available for this TT2 PR.

Copy link
Contributor

@hellofromtonya hellofromtonya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Used this PR for testing the internal-only theme.json webfonts handler (see PR #2622 and commit https://core.trac.wordpress.org/changeset/53282). Works well 👍

@jffng
Copy link

jffng commented Apr 26, 2022

Committed in https://core.trac.wordpress.org/changeset/53286/, thanks for all the work and consideration to make this happen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants