Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport script loader: enqueue stored block supports styles #3218

Conversation

ramonjd
Copy link
Member

@ramonjd ramonjd commented Sep 9, 2022

❗ BLOCKED by #3199

Backporting changes to script-loader that enqueue block support styles stored by the style engine/

See tracking issue: WordPress/gutenberg#43440

Backporting the following changes

Trac ticket: https://core.trac.wordpress.org/ticket/56467


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

Backporting block supports filter callback and registrations
@ramonjd ramonjd force-pushed the add/enqueue-stored-block-supports-styles branch from cbadece to 25b977c Compare September 9, 2022 11:22
<?php

/**
* Tests functions and classes for widgets and sidebars.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name needs to get updated.

*
* @group script-loader
*/
class Tests_Script_Loader extends WP_UnitTestCase {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It probably would fit better next to other tests for global styles.

@ockham
Copy link
Contributor

ockham commented Sep 15, 2022

I'll fork this so I can rebase and address @gziolo's suggestions.

@ockham
Copy link
Contributor

ockham commented Sep 15, 2022

I'll fork this so I can rebase and address @gziolo's suggestions.

#3259

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

3 participants