Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport the changes to the site editor intialization #3855

Closed

Conversation

youknowriad
Copy link
Contributor

Trac ticket https://core.trac.wordpress.org/ticket/57480

Related Gutenberg PRs:

WordPress/gutenberg#44770

This updates the site initialization to match Gutenberg by removing a key that is not used anymore. That said, we can't land this PR until the package updates happens.

@Mamaduka @ntsekouras

@youknowriad youknowriad self-assigned this Jan 17, 2023
Copy link
Contributor

@hellofromtonya hellofromtonya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the original Gutenberg PR, it unsets this setting:

unset( $settings['__unstableHomeTemplate'] );

The appropriate change then in Core is to remove the setting.

LGTM 👍

@hellofromtonya
Copy link
Contributor

What are risks to users and extenders by hard removing this setting?
Thinking of backwards-compatibility (BC)

Searched the wporg repos for usage:

@ntsekouras
Copy link

What are risks to users and extenders by hard removing this setting?
Thinking of backwards-compatibility (BC)

It seems there is no BC issue. It was discussed in the original GB PR.

@youknowriad youknowriad force-pushed the backport/site-editor-php branch from f344fe1 to 08629ea Compare February 7, 2023 07:07
@youknowriad
Copy link
Contributor Author

@youknowriad youknowriad closed this Feb 7, 2023
@youknowriad youknowriad deleted the backport/site-editor-php branch February 7, 2023 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants