Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTML API: Remove all duplicate copies of an attribute when removing #4317

Closed
wants to merge 1 commit into from
Closed

HTML API: Remove all duplicate copies of an attribute when removing #4317

wants to merge 1 commit into from

Commits on Sep 25, 2023

  1. HTML API: Delete all copies of an attribute when removing and duplica… 

    …tes exist. (WordPress#4317)

When encountering an HTML tag with duplicate copies of an attribute the tag
processor ignores the duplicate values, according to the specification. However,
when removing an attribute it must remove all copies of that attribute lest
one of the duplicates becomes the primary and it appears as if no attributes
were removed.

In this patch we're adding tests that will be used to ensure that all attribute
copies are removed from a tag when one is requested to be removed.

Co-authored-by: Bernie Reiter <96308+ockham@users.noreply.github.com>
    @dmsnell @ockham
    dmsnell and ockham committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    2098d0c View commit details
    Browse the repository at this point in the history