-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WP Backport Block Supports: Add text columns (column count) to typography block supports #4622
Conversation
@aaronrobertshaw do these ported changes look okay to you? |
e3f0f2c
to
3380152
Compare
Thank you for wrangling this backport @ramonjd I think we might need to also backport the addition of The changes in this PR look good in terms of addressing WordPress/gutenberg#33587 though. |
Good spotting. I'll add it to this PR. 👍 thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for putting this up @ramonjd ! I spotted a missing since comment and added it in 😄
Code LGTM and in accordance with the Gutenberg PRs; it won't really be testable in the UI until npm packages are updated but I can confirm everything else in the typography support is still working correctly.
This PR adds the PHP changes for the following Gutenberg PRs:
Frontend changes also need to be ported and will be done before WP 6.3 beta (before June 27)
Testing:
npm run test:php -- --filter Tests_Theme_wpThemeJson
Trac ticket: https://core.trac.wordpress.org/ticket/58549