Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WP Backport Block Supports: Add text columns (column count) to typography block supports #4622

Closed

Conversation

ramonjd
Copy link
Member

@ramonjd ramonjd commented Jun 16, 2023

This PR adds the PHP changes for the following Gutenberg PRs:

Frontend changes also need to be ported and will be done before WP 6.3 beta (before June 27)

Testing:

npm run test:php -- --filter Tests_Theme_wpThemeJson

Trac ticket: https://core.trac.wordpress.org/ticket/58549

@ramonjd
Copy link
Member Author

ramonjd commented Jun 20, 2023

@aaronrobertshaw do these ported changes look okay to you?

@ramonjd ramonjd force-pushed the add/typography-columns-support branch from e3f0f2c to 3380152 Compare June 21, 2023 00:20
@aaronrobertshaw
Copy link

Thank you for wrangling this backport @ramonjd

I think we might need to also backport the addition of textColumns support to the style engine which was added to Gutenberg in WordPress/gutenberg#46566. As it's all for one feature, should that be part of this backport or separate?

The changes in this PR look good in terms of addressing WordPress/gutenberg#33587 though.

@ramonjd
Copy link
Member Author

ramonjd commented Jun 21, 2023

I think we might need to also backport the addition of textColumns support to the style engine which was added to Gutenberg in WordPress/gutenberg#46566.

Good spotting. I'll add it to this PR. 👍

thanks

@ramonjd ramonjd changed the title Block Supports: Add text columns (column count) to typography block supports WP Backport Block Supports: Add text columns (column count) to typography block supports Jun 22, 2023
Copy link
Contributor

@tellthemachines tellthemachines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this up @ramonjd ! I spotted a missing since comment and added it in 😄

Code LGTM and in accordance with the Gutenberg PRs; it won't really be testable in the UI until npm packages are updated but I can confirm everything else in the typography support is still working correctly.

@tellthemachines
Copy link
Contributor

Committed in r55985 / 9a9a672.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

3 participants