Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore fonts upload folder #5190

Conversation

ironprogrammer
Copy link

@ironprogrammer ironprogrammer commented Sep 11, 2023

Adds the /src/wp-content/fonts directory to .gitignore, treating it like the plugins and uploads directories. The fonts upload storage location was most recently updated in WordPress/gutenberg#54122.

Discussions around where to store installed fonts can be found here, and later here.

Trac ticket: https://core.trac.wordpress.org/ticket/59166


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@ironprogrammer ironprogrammer force-pushed the add/ignore-fonts-upload-directory branch from f210cbe to a35028a Compare January 26, 2024 21:55
Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@swissspidy
Copy link
Member

Fixed in https://core.trac.wordpress.org/changeset/57640

@swissspidy swissspidy closed this Feb 16, 2024
@ironprogrammer ironprogrammer deleted the add/ignore-fonts-upload-directory branch February 16, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants