Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image: Add the lightbox setting to theme.json #5248

Conversation

michalczaplinski
Copy link
Contributor

This is a backport PR for WordPress 6.4 that includes the following PHP Gutenberg changes:

Trac ticket: https://core.trac.wordpress.org/ticket/59393


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

Copy link
Contributor

@tellthemachines tellthemachines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! The changes from lib/theme.json in the linked Gutenberg PR should also be added to the core theme.json file.

This can't really be tested in core without the scripts that will only be available after the packages are updated, but the changes don't break anything so should be safe to commit beforehand.

@tellthemachines tellthemachines force-pushed the update/lightbox-setting-theme-json branch from ee07015 to 348253a Compare September 21, 2023 05:44
@tellthemachines
Copy link
Contributor

Added the theme.json change and rebased the branch to see if tests pass.

Copy link
Contributor

@tellthemachines tellthemachines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're good to go with this! ✅

@tellthemachines
Copy link
Contributor

Committed in r56643.

@michalczaplinski
Copy link
Contributor Author

Thanks for the PR! The changes from lib/theme.json in the linked Gutenberg PR should also be added to the core theme.json file.

Thanks for following up on this @tellthemachines and sorry I didn't get to it yesterday! 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants