-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add $schema to block and theme JSON #5868
Conversation
Files in |
Good to know, thanks! I reverted the changes to |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
@sirreal it looks like some of these should come over through the normal package update process? do you know if this is true? |
|
tests/phpunit/data/themedir1/block-theme-with-hooked-blocks/blocks/hooked-after/block.json
Outdated
Show resolved
Hide resolved
I've taken the liberty of slightly tweaking the test hooked blocks' names in 126b31b. Hope that's okay! 😊 |
Looks good, thanks @ockham. |
Committed to Core in https://core.trac.wordpress.org/changeset/57336. |
Add $schema to block.json and theme.json files.
Note that not all files are valid according to the schema. I'm working on those fixes in WordPress/gutenberg#57374 and will port those changes when they're finished.
Some of the invalid (according to the schema) block and theme json files are in phpunit tests were invalid due to missing
title
properties. In those cases I've fixed the json to satisfy the schema. Those changes have no impact on the runtime whatsoever and do not change the result of unit tests.This is a port of WordPress/gutenberg#57201
Trac ticket: https://core.trac.wordpress.org/ticket/60255
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.