Layout: backport fix to ensure blocks without layout support do not receive layout classnames #5900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
tellthemachines
approved these changes
Jan 23, 2024
|
Committed in r57328. |
|
Thanks for reviewing and committing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport changes from the Gutenberg plugin in: WordPress/gutenberg#56187
Prevent layout classnames from being output on blocks where there is no layout support and child layout classnames are not being output. An example is a paragraph that is a child of a group block, and that has
selfStretchset tofit. In this case, no layout classnames should be added to the paragraph block, but prior to WordPress/gutenberg#56187 they were being added unexpectedly.This PR also adds a test to cover the fix. For further context and sample test markup, see the PR description of WordPress/gutenberg#56187
Trac ticket: https://core.trac.wordpress.org/ticket/60292
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.