HTML API: Add select handling #5908

sirreal · 2024-01-19T17:51:47Z

A start tag whose tag name is "select"
Reconstruct the active formatting elements, if any.

Insert an HTML element for the token.

Set the frameset-ok flag to "not ok".

If the insertion mode is one of "in table", "in caption", "in table body", "in row", or "in cell", then switch the insertion mode to "in select in table". Otherwise, switch the insertion mode to "in select".

Skip fewer of the html5lib-tests:

 OK, but incomplete, skipped, or risky tests!
-Tests: 607, Assertions: 174, Skipped: 433.
+Tests: 607, Assertions: 184, Skipped: 423.

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

github-actions · 2024-01-21T20:39:32Z

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

The Plugin and Theme Directories cannot be accessed within Playground.
All changes will be lost when closing a tab with a Playground instance.
All changes will be lost when refreshing the page.
A fresh instance is created each time the link below is clicked.
Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

github-actions · 2024-02-02T15:13:55Z

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props jonsurrell, dmsnell.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

sirreal · 2024-07-04T14:31:30Z

@dmsnell This is ready for review.

src/wp-includes/html-api/class-wp-html-open-elements.php

src/wp-includes/html-api/class-wp-html-processor.php

This reverts commit 9d99844.

src/wp-includes/html-api/class-wp-html-processor.php

sirreal · 2024-07-04T19:30:22Z

src/wp-includes/html-api/class-wp-html-open-elements.php

+	 * @return bool True if there are nodes on the stack and the top node has
+	 *              a matching node_name.
+	 */
+	public function current_node_is( string $node_name ): bool {


This is from #6968.

sirreal · 2024-07-04T19:39:34Z

src/wp-includes/html-api/class-wp-html-processor.php

+	 *
+	 * @return bool Whether an element was found.
+	 */
+	private function step_in_head() {


We should stub out the rest of these step_in_* methods.

dmsnell · 2024-07-04T22:08:13Z

src/wp-includes/html-api/class-wp-html-open-elements.php

+	/**
+	 * Checks if the node at the top of the stack matches provided node name.
+	 *
+	 * @example


I believe that this style of example only comes over from the Gutenberg end, and to play well with the WordPress documentation we should follow this pattern

/** * * Example: * * // Is the current node a text node? * $stack->current_node_is( '#text' ); * * // Is the current node a DIV element? * $stack->current_node_is( 'DIV' ); */

That is: Example:, a blank line, and then four spaces to indent the code. This works well with various IDE support thankfully.

dmsnell · 2024-07-04T22:11:39Z

src/wp-includes/html-api/class-wp-html-processor.php

+	 * This internal function performs the 'in head' insertion mode
+	 * logic for the generalized WP_HTML_Processor::step() function.
+	 *
+	 * @since 6.7.0


Can note that this is a stub.

dmsnell · 2024-07-04T22:16:53Z

src/wp-includes/html-api/class-wp-html-processor.php

+			 */
+			case '#text':
+				$this->insert_html_element( $this->state->current_token );
+				return true;


we should perform the same check as we do in IN BODY for null text, as we don't really want to create a new node or pause just for them. that is, if the text node comprises only null bytes, ignore the token.

note that this rule only applies to null bytes directly. it does not apply if the null byte is encoded as a character reference. in that case, the character references  and  both decode to the Unicode replacement character �

dmsnell · 2024-07-04T22:20:57Z

src/wp-includes/html-api/class-wp-html-processor.php

+
+			/*
+			 * > An end tag whose tag name is "select"
+			 * > A start tag whose tag name is "select"


It's worth it IMO to add the quote from the spec, the "Note"

/* * > It just gets treated like an end tag. */

dmsnell · 2024-07-04T22:21:19Z

src/wp-includes/html-api/class-wp-html-processor.php

+			case '-SELECT':
+			case '+SELECT':
+				if ( ! $this->state->stack_of_open_elements->has_element_in_select_scope( 'SELECT' ) ) {
+					return $this->step();


Comment: Ignore the token

dmsnell · 2024-07-04T22:22:32Z

src/wp-includes/html-api/class-wp-html-processor.php

+					return $this->step();
+				}
+				$this->state->stack_of_open_elements->pop_until( 'SELECT' );
+				$this->state->stack_of_open_elements->pop();


this is superfluous, because pop_until() pops the requested node.

Pops nodes off of the stack of open elements until one with the given tag name has been popped.

dmsnell · 2024-07-04T22:23:31Z

src/wp-includes/html-api/class-wp-html-processor.php

+			case '+INPUT':
+			case '+KEYGEN':
+			case '+TEXTAREA':
+				// Parse error.


This look like it's describing the next line, the if, but it's just a general remark that this entire case is a parse error. Probably best to move it above in the comment for the cluster of tags.

dmsnell · 2024-07-04T22:23:49Z

src/wp-includes/html-api/class-wp-html-processor.php

+			case '+TEXTAREA':
+				// Parse error.
+				if ( ! $this->state->stack_of_open_elements->has_element_in_select_scope( 'SELECT' ) ) {
+					return $this->step();


Comment: Ignore token.

dmsnell · 2024-07-04T22:24:43Z

src/wp-includes/html-api/class-wp-html-processor.php

+			case '+SCRIPT':
+			case '+TEMPLATE':
+			case '-TEMPLATE':
+				return $this->step_in_head();


Comment: Process the token using the rules for the "in head" insertion mode.

dmsnell

@sirreal I've applied a number of changes including two notables:

I've added all of the remaining tags to generate_implied_end_tag() in order to lighten the burden as we add the remaining tag support.
After noticing a defect in that algorithm (caching current_element()) I've updated the logic to be clearer and to ensure that it's always checking the updated current element.

After these changes, three more tests pass that were previously skipped. That could be related to the bug in generate_implied_end_tags() but I didn't investigate.

As part of work to add more spec support to the HTML API, this patch adds support for the SELECT, OPTION, and OPTGROUP elements, including the requisite support for the IN SELECT insertion mode. Developed in #5908 Discussed in https://core.trac.wordpress.org/ticket/61576 Props dmsnell, jonsurrell. See #61576. git-svn-id: https://develop.svn.wordpress.org/trunk@58677 602fd350-edb4-49c9-b593-d223f7449a82

dmsnell · 2024-07-05T00:54:01Z

Merged in [58677]
c1154f9

As part of work to add more spec support to the HTML API, this patch adds support for the SELECT, OPTION, and OPTGROUP elements, including the requisite support for the IN SELECT insertion mode. Developed in WordPress/wordpress-develop#5908 Discussed in https://core.trac.wordpress.org/ticket/61576 Props dmsnell, jonsurrell. See #61576. Built from https://develop.svn.wordpress.org/trunk@58677 git-svn-id: http://core.svn.wordpress.org/trunk@58079 1a063a9b-81f0-0310-95a4-ce76da25c4cd

As part of work to add more spec support to the HTML API, this patch adds support for the SELECT, OPTION, and OPTGROUP elements, including the requisite support for the IN SELECT insertion mode. Developed in WordPress/wordpress-develop#5908 Discussed in https://core.trac.wordpress.org/ticket/61576 Props dmsnell, jonsurrell. See #61576. Built from https://develop.svn.wordpress.org/trunk@58677 git-svn-id: https://core.svn.wordpress.org/trunk@58079 1a063a9b-81f0-0310-95a4-ce76da25c4cd

sirreal force-pushed the html-api/handle-select-tag branch from 083f678 to 68609de Compare January 21, 2024 20:01

This comment was marked as outdated.

Sign in to view

sirreal force-pushed the html-api/handle-select-tag branch from d53fe6c to e2eee29 Compare January 21, 2024 20:15

sirreal force-pushed the html-api/handle-select-tag branch from e2eee29 to 5216819 Compare January 23, 2024 12:30

sirreal force-pushed the html-api/handle-select-tag branch from 5216819 to 6f6c2ae Compare February 2, 2024 15:13

sirreal force-pushed the html-api/handle-select-tag branch 2 times, most recently from af836be to 1cd3a08 Compare February 2, 2024 15:19

sirreal force-pushed the html-api/handle-select-tag branch from 1cd3a08 to 0d34838 Compare June 13, 2024 14:43

sirreal mentioned this pull request Jul 2, 2024

HTML API: Implement reset_insertion_mode #6020

Closed

dmsnell mentioned this pull request Jul 2, 2024

HTML API: Plans for 6.7 WordPress/gutenberg#60396

Open

19 tasks

sirreal force-pushed the html-api/handle-select-tag branch from 0d34838 to 5964758 Compare July 3, 2024 18:53

sirreal added 7 commits July 4, 2024 13:29

Implement SELECT and related tags handling

b867b58

Remove SELECT from unsupported elements test

9245930

Remove SELECT scope optgroup/option tests

267a27b

Remove SELECT, OPTION, OPTGROUP from unsupported tags

b0475fb

Remove OPTION,OPTGROUP from gen implied end tags unsupported test

1944b66

Add OPTION, OPTGROUP to implied end tags

8d4b4df

Update step_in_select since tag

1404119

sirreal force-pushed the html-api/handle-select-tag branch from 87fa7e9 to 81dd7f5 Compare July 4, 2024 11:56

sirreal added 2 commits July 4, 2024 16:15

Update since tags on in_select_scope

dc0bbb9

Implement in_select_scope via …in_specific_scope

9d99844

sirreal force-pushed the html-api/handle-select-tag branch from 81dd7f5 to 9d99844 Compare July 4, 2024 14:25

sirreal marked this pull request as ready for review July 4, 2024 14:31

sirreal mentioned this pull request Jul 4, 2024

HTML API: Add table support #6040

Closed

dmsnell reviewed Jul 4, 2024

View reviewed changes

Revert "Implement in_select_scope via …in_specific_scope"

3085405

This reverts commit 9d99844.

dmsnell reviewed Jul 4, 2024

View reviewed changes

src/wp-includes/html-api/class-wp-html-processor.php Outdated Show resolved Hide resolved

sirreal added 7 commits July 4, 2024 21:23

Handle +HTML case

52fd8e5

Update several cases to use current_node_is

6a10eb0

Simplify -OPTGROUP handling implementation

8b3a9e4

Add input,keygen,textarea,script,template handling

87c6596

Add "anything else" handling

d464330

Add step_in_head stub

ddbd676

Multi-line comments should be block comments

f6d686d

sirreal commented Jul 4, 2024

View reviewed changes

sirreal added 2 commits July 4, 2024 21:32

fixup! Update several cases to use current_node_is

783cef6

Fix step_in_head documentation block

3222275

sirreal commented Jul 4, 2024

View reviewed changes

sirreal requested a review from dmsnell July 4, 2024 19:41

dmsnell reviewed Jul 4, 2024

View reviewed changes

dmsnell added 2 commits July 4, 2024 16:22

Merge branch 'trunk' into html-api/handle-select-tag

eb126e8

Apply feedback requests.

f2e1d03

dmsnell reviewed Jul 5, 2024

View reviewed changes

dmsnell closed this Jul 5, 2024

dmsnell deleted the html-api/handle-select-tag branch July 5, 2024 00:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HTML API: Add select handling #5908

HTML API: Add select handling #5908

sirreal commented Jan 19, 2024 •

edited by dmsnell

Loading

This comment was marked as outdated.

github-actions bot commented Jan 21, 2024

github-actions bot commented Feb 2, 2024 •

edited

Loading

sirreal commented Jul 4, 2024

sirreal Jul 4, 2024

sirreal Jul 4, 2024

dmsnell Jul 4, 2024

dmsnell Jul 4, 2024

dmsnell Jul 4, 2024

dmsnell Jul 4, 2024

dmsnell Jul 4, 2024

dmsnell Jul 4, 2024

dmsnell Jul 4, 2024

dmsnell Jul 4, 2024

dmsnell Jul 4, 2024

dmsnell left a comment •

edited

Loading

dmsnell commented Jul 5, 2024

HTML API: Add select handling #5908

HTML API: Add select handling #5908

Conversation

sirreal commented Jan 19, 2024 • edited by dmsnell Loading

This comment was marked as outdated.

github-actions bot commented Jan 21, 2024

Test using WordPress Playground

Some things to be aware of

github-actions bot commented Feb 2, 2024 • edited Loading

sirreal commented Jul 4, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dmsnell left a comment • edited Loading

Choose a reason for hiding this comment

dmsnell commented Jul 5, 2024

sirreal commented Jan 19, 2024 •

edited by dmsnell

Loading

github-actions bot commented Feb 2, 2024 •

edited

Loading

dmsnell left a comment •

edited

Loading