Block Hooks: Update PHPDoc for context arg #5946
Conversation
|
cc/ Editor Tech Leads @getdave @youknowriad |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
| * @param string $relative_position The relative position of the hooked blocks. | ||
| * Can be one of 'before', 'after', 'first_child', or 'last_child'. | ||
| * @param string $anchor_block_type The anchor block type. | ||
| * @param WP_Block_Template|WP_Post|array $context The block template, template part, `wp_navigation` post type, |
There was a problem hiding this comment.
This needs to be noted in the dev note as potentially it could break things if someone assumed:
if ( ! $context instanceof WP_Block_Template ) // process as it was an array
|
Is this ready to be committed, what's left here? |
Maybe let's wait for @ockham to confirm. There might be now a bit different approach used. |
|
Should be ready to go! Thanks all 😊 |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core SVNCore Committers: Use this line as a base for the props when committing in SVN: GitHub Merge commitsIf you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
See WordPress/gutenberg#57754 (comment).
Commit this to Core once npm packages have been synced from Gutenberg (see #5922) to include WordPress/gutenberg#57754.
See https://core.trac.wordpress.org/ticket/59743.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.