Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTML API: Add table support #6040

Closed
wants to merge 59 commits into from
Closed

HTML API: Add table support #6040

wants to merge 59 commits into from

Commits on Jul 5, 2024

  1. Work on table support

    @sirreal
    sirreal committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    9ec4b31 View commit details
    Browse the repository at this point in the history

  2. table processing

    @sirreal
    sirreal committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    ab408c1 View commit details
    Browse the repository at this point in the history

  3. Disable FRAME / HEAD

    @sirreal
    sirreal committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    5ec8ffe View commit details
    Browse the repository at this point in the history

  4. In table body rules

    @sirreal
    sirreal committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    2be4e63 View commit details
    Browse the repository at this point in the history

  5. prep step_in_row

    @sirreal
    sirreal committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    0c0484c View commit details
    Browse the repository at this point in the history

  6. Remove unsupported table element tests

    @sirreal
    sirreal committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    b91df28 View commit details
    Browse the repository at this point in the history

  7. phpcbf and implement in row

    @sirreal
    sirreal committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    84b3c74 View commit details
    Browse the repository at this point in the history

  8. Add clear_up_to_last_marker to active formatting 

    This is an algorithm defined in the standard:
https://html.spec.whatwg.org/multipage/parsing.html#clear-the-list-of-active-formatting-elements-up-to-the-last-marker
    @sirreal
    sirreal committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    1a90c26 View commit details
    Browse the repository at this point in the history

  9. Add step_in_cell method

    @sirreal
    sirreal committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    dafe4ea View commit details
    Browse the repository at this point in the history

  10. Use class name for processor state constants access

    @sirreal
    sirreal committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    cd8d7e7 View commit details
    Browse the repository at this point in the history

  11. Update since tags

    @sirreal
    sirreal committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    a7b565b View commit details
    Browse the repository at this point in the history

  12. Add close_cell method

    @sirreal
    sirreal committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    3971e2b View commit details
    Browse the repository at this point in the history

  13. Pop from open elements instead of removing items

    @sirreal
    sirreal committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    6316e4b View commit details
    Browse the repository at this point in the history

  14. Complete cases in step_in_table

    @sirreal
    sirreal committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    cff5faa View commit details
    Browse the repository at this point in the history

  15. Implement in_table_scope

    @sirreal
    sirreal committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    6ef9df9 View commit details
    Browse the repository at this point in the history

  16. Add HTML elements to has_element_in_scope handling

    @sirreal
    sirreal committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    9c59014 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2024

  1. Merge remote-tracking branch 'upstream/trunk' into html-api/add-table… 

    …-support
    @sirreal
    sirreal committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    2ded522 View commit details
    Browse the repository at this point in the history

  2. Use insert_marker over set_marker 

    Use the method implemented in WordPress#6982
to avoid duplicating the same functionality.
    @sirreal
    sirreal committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    fce641d View commit details
    Browse the repository at this point in the history

  3. Use newly implemented step_in_X methods 

    Instead of bailing directly, call the appropriate step_in_ method.
    @sirreal
    sirreal committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    693a791 View commit details
    Browse the repository at this point in the history

  4. Clean whitespace

    @sirreal
    sirreal committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    d688c10 View commit details
    Browse the repository at this point in the history

  5. Use bail method in case of foster parenting

    @sirreal
    sirreal committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    39eba92 View commit details
    Browse the repository at this point in the history

  6. Add mising cell insertion mode on enter td,th

    @sirreal
    sirreal committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    2a3d7d4 View commit details
    Browse the repository at this point in the history

  7. PHPCBF

    @sirreal
    sirreal committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    ff7541c View commit details
    Browse the repository at this point in the history

  8. Use todo comments for parse errors

    @sirreal
    sirreal committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    2cf10df View commit details
    Browse the repository at this point in the history

  9. Remove EOF comment

    @sirreal
    sirreal committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    a216d55 View commit details
    Browse the repository at this point in the history

  10. Move stack methods to stack class

    @sirreal
    sirreal committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    7d7f688 View commit details
    Browse the repository at this point in the history

  11. Add and use form_element pointer

    @sirreal
    sirreal committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    e171589 View commit details
    Browse the repository at this point in the history

  12. Handle presumptuous tags as if they were comments

    @sirreal
    sirreal committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    fbd635d View commit details
    Browse the repository at this point in the history

  13. Add test for table > form > #comment

    @sirreal
    sirreal committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    af1142a View commit details
    Browse the repository at this point in the history

  14. Pop FORM elements off the stack in tables

    @sirreal
    sirreal committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    a7f5a22 View commit details
    Browse the repository at this point in the history

  15. Be more consistent in parse error comments

    @sirreal
    sirreal committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    a6a7c7d View commit details
    Browse the repository at this point in the history

  16. Remove outdated "stub implementation" notes

    @sirreal
    sirreal committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    345b776 View commit details
    Browse the repository at this point in the history

  17. Add return types

    @sirreal
    sirreal committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    4966e7a View commit details
    Browse the repository at this point in the history

  18. Handle whitespace in TABLE text

    @sirreal
    sirreal committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    c111a74 View commit details
    Browse the repository at this point in the history

  19. Fix table start tag handling

    @sirreal
    sirreal committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    c7f6da6 View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2024

  1. Remove "COL" from void tags test 

    The COL element can only appear in TABLE and is not suitable for the
void tag nesting test.
    @sirreal
    sirreal committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    d14eaf3 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/trunk' into html-api/add-table… 

    …-support
    @sirreal
    sirreal committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    0ce8fc4 View commit details
    Browse the repository at this point in the history

  3. Fix handling of table text according to specification

    @sirreal
    sirreal committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    eaa8359 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2024

  1. Expand text processing comment and whitespace special character form

    @sirreal
    sirreal committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    380b9c6 View commit details
    Browse the repository at this point in the history

  2. Fix comment whitespace

    @sirreal
    sirreal committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    9957194 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2024

  1. Clarify empty check after processing and null-remove

    @sirreal
    sirreal committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    ffd0e1c View commit details
    Browse the repository at this point in the history

  2. Use consistent "\n" style character escapes 

    Follow the most common whitespace character escape forms.
Quote the spec referencing the ASCII whitespace characters.
List the characters in the same order mentioned in the spec.
    @sirreal
    sirreal committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    f49812e View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2024

  1. Merge branch 'trunk' into html-api/add-table-support

    @dmsnell
    dmsnell committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    d9aa8fb View commit details
    Browse the repository at this point in the history

  2. Remove redundant null byte text replacement

    @sirreal
    sirreal committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    40b55b4 View commit details
    Browse the repository at this point in the history

  3. Apply suggestion to compare multiple elements against node name

    @sirreal
    sirreal committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    9046cb3 View commit details
    Browse the repository at this point in the history

  4. Add spec quote when generating a COLGROUP token 

    The spec inserts some elements not present in the DOM to preserve proper
table structure. Add explanatory comment.
    @sirreal
    sirreal committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    e4b874c View commit details
    Browse the repository at this point in the history

  5. Add spec quote when generating a TBODY token 

    The spec inserts some elements not present in the DOM to preserve proper
table structure. Add explanatory comment.
    @sirreal
    sirreal committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    1cca15f View commit details
    Browse the repository at this point in the history

  6. Use goto for safer move to "anything else" condition

    @sirreal
    sirreal committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    b29e1d3 View commit details
    Browse the repository at this point in the history

  7. Revert "Remove "COL" from void tags test" 

    This reverts commit d14eaf3.
    @sirreal
    sirreal committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    3f780fc View commit details
    Browse the repository at this point in the history

  8. fixup! Apply suggestion to compare multiple elements against node name

    @sirreal
    sirreal committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    b44f7a3 View commit details
    Browse the repository at this point in the history

  9. Add comment for no-quirks p table nesting

    @sirreal
    sirreal committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    085950e View commit details
    Browse the repository at this point in the history

  10. Remove strspn default args

    @sirreal
    sirreal committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    e057ff9 View commit details
    Browse the repository at this point in the history

  11. Remove assertion in implementation from HTML spec 

    Assertions from the spec are explicitly optional in implementation.

Remove the assertion, it's checking an invariant condition.
    @sirreal
    sirreal committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    dc752ff View commit details
    Browse the repository at this point in the history

  12. Adjust code after review.

    @dmsnell
    dmsnell committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    2cfe504 View commit details
    Browse the repository at this point in the history

  13. Remove typo.

    @dmsnell
    dmsnell committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    9590793 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2024

  1. Fix HTML spec quoting close_cell method 

    The "> …" quoting omitted part of the quoted spec. Include the complete
spec in the quoting.
    @sirreal
    sirreal committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    cf16373 View commit details
    Browse the repository at this point in the history

  2. Use pop instruction for form elements that are immediately popped in … 

    …table
    @sirreal
    sirreal committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    4c4bfc8 View commit details
    Browse the repository at this point in the history

  3. Remove unwanted change to expects-closer

    @dmsnell
    dmsnell committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    0686de8 View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'upstream/trunk' into html-api/add-table… 

    …-support
    @dmsnell
    dmsnell committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    d43c220 View commit details
    Browse the repository at this point in the history