-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Styles: Level global styles specificity at 0-1-0 #6633
Styles: Level global styles specificity at 0-1-0 #6633
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN:
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
@tellthemachines and @andrewserong, if you get the chance, it would be great if you could confirm this backport covers all it should from previous zero-specificity work and the closed PR: #6522 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM and it's testing correctly on my local. Just need to add @since 6.6.0
(for functions) and @ticket [ticket number]
(for tests) and should be good to go!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
46f9776
to
0ab91d1
Compare
Thanks for the reviews and nudge to get the since/ticket comments in place. That's been done now. I've also given this a rebase and updated the new background image test for theme.json. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update! This is looking good to me now 🎉
Committed in r58241. |
To make overriding core styles easier and enable the extension of block style variations as a means for section styling, it is necessary to limit the specificity of global styles CSS output.
Further context can be found in: WordPress/gutenberg#57537
Syncs changes from:
Trac ticket: https://core.trac.wordpress.org/ticket/61165
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.