HTML API: Add tests for comments #6765
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
sirreal
force-pushed
the
html-api/add-comment-tests
branch
from
e21740c
to
909e095
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
sirreal
commented
Jun 28, 2024
aaronjorbin
reviewed
Jun 28, 2024
|
Good suggestions, thanks @aaronjorbin. I've applied them. |
dmsnell
reviewed
Jun 28, 2024
|
Thanks @dmsnell, I applied those suggestions and cleaned things up. The signatures do become much simpler when we split the |
demonstrates regression from push/pop
Use two different tests with much simpler function signatures.
sirreal
force-pushed
the
html-api/add-comment-tests
branch
from
a2afbde
to
067597e
Compare
dmsnell
approved these changes
Jul 16, 2024
pento
pushed a commit
that referenced
this pull request
Jul 16, 2024
There was a bug-fix late in the 6.6 cycle in the HTML Processor which resolved an issue with the wrong name being reported when paused at processing-instruction look-alike invalid comments, but no tests were added to enforce the correct behaviors. This patch adds the missing tests. Developed in #6765 Discussed in https://core.trac.wordpress.org/ticket/61530 Follow-up to [58304], [58558]. Props dmsnell, jonsurrell. See #61530. git-svn-id: https://develop.svn.wordpress.org/trunk@58734 602fd350-edb4-49c9-b593-d223f7449a82
19 tasks
github-actions bot
pushed a commit
to gilzow/wordpress-performance
that referenced
this pull request
Jul 16, 2024
There was a bug-fix late in the 6.6 cycle in the HTML Processor which resolved an issue with the wrong name being reported when paused at processing-instruction look-alike invalid comments, but no tests were added to enforce the correct behaviors. This patch adds the missing tests. Developed in WordPress/wordpress-develop#6765 Discussed in https://core.trac.wordpress.org/ticket/61530 Follow-up to [58304], [58558]. Props dmsnell, jonsurrell. See #61530. Built from https://develop.svn.wordpress.org/trunk@58734 git-svn-id: https://core.svn.wordpress.org/trunk@58136 1a063a9b-81f0-0310-95a4-ce76da25c4cd
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
Jul 16, 2024
There was a bug-fix late in the 6.6 cycle in the HTML Processor which resolved an issue with the wrong name being reported when paused at processing-instruction look-alike invalid comments, but no tests were added to enforce the correct behaviors. This patch adds the missing tests. Developed in WordPress/wordpress-develop#6765 Discussed in https://core.trac.wordpress.org/ticket/61530 Follow-up to [58304], [58558]. Props dmsnell, jonsurrell. See #61530. Built from https://develop.svn.wordpress.org/trunk@58734 git-svn-id: http://core.svn.wordpress.org/trunk@58136 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Debarghya-Banerjee
pushed a commit
to Debarghya-Banerjee/wordpress-develop
that referenced
this pull request
Jul 18, 2024
There was a bug-fix late in the 6.6 cycle in the HTML Processor which resolved an issue with the wrong name being reported when paused at processing-instruction look-alike invalid comments, but no tests were added to enforce the correct behaviors. This patch adds the missing tests. Developed in WordPress#6765 Discussed in https://core.trac.wordpress.org/ticket/61530 Follow-up to [58304], [58558]. Props dmsnell, jonsurrell. See #61530. git-svn-id: https://develop.svn.wordpress.org/trunk@58734 602fd350-edb4-49c9-b593-d223f7449a82
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trac ticket: Core-61530
Add tests for comment handling.
These tests caught a regression during the 6.6 development cycle (with processing instruction comment tag name) that was fixed, but the tests were not merged.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.