Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block bindings: Add support for image caption #6838

Open
wants to merge 18 commits into
base: trunk
Choose a base branch
from
Open

Block bindings: Add support for image caption #6838

wants to merge 18 commits into from

Commits on Jul 1, 2024

  1. Add support for image caption

    @SantosGuillamot
    SantosGuillamot committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    f584ad4 View commit details
    Browse the repository at this point in the history

  2. Use HTML_Processor instead of HTML_Tag_Processor

    @SantosGuillamot
    SantosGuillamot committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    7d7d5c3 View commit details
    Browse the repository at this point in the history

  3. Move anonymous class inside image conditional

    @SantosGuillamot
    SantosGuillamot committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    731d869 View commit details
    Browse the repository at this point in the history

  4. Remove release_bookmark calls

    @SantosGuillamot
    SantosGuillamot committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    c360edf View commit details
    Browse the repository at this point in the history

  5. Don't grab bookmarks until the end

    @SantosGuillamot
    SantosGuillamot committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    afbf38c View commit details
    Browse the repository at this point in the history

  6. Add checks to ensure it doesn't replace unwanted html

    @SantosGuillamot
    SantosGuillamot committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    cbe79ee View commit details
    Browse the repository at this point in the history

  7. Add comments to clarify the set_inner_text function

    @SantosGuillamot
    SantosGuillamot committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    083c4e2 View commit details
    Browse the repository at this point in the history

  8. Clarify comments

    @SantosGuillamot
    SantosGuillamot committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    01d0e86 View commit details
    Browse the repository at this point in the history

  9. Add unit test for processing

    @SantosGuillamot
    SantosGuillamot committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    632e015 View commit details
    Browse the repository at this point in the history

  10. Restrict method to figcaption 

    Co-authored-by: Luis Herranz <luisherranz@gmail.com>
    @SantosGuillamot @luisherranz
    SantosGuillamot and luisherranz committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    79013a9 View commit details
    Browse the repository at this point in the history

  11. Call function properly

    @SantosGuillamot
    SantosGuillamot committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    cf25d7d View commit details
    Browse the repository at this point in the history

  12. Fix figcaption conditional

    @SantosGuillamot
    SantosGuillamot committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    88df640 View commit details
    Browse the repository at this point in the history

  13. Update private method comment

    @SantosGuillamot
    SantosGuillamot committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    1c4ac72 View commit details
    Browse the repository at this point in the history

  14. Use alternative method

    @SantosGuillamot
    SantosGuillamot committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    ac43482 View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2024

  1. Set opening bookmark

    @SantosGuillamot
    SantosGuillamot committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    19465c0 View commit details
    Browse the repository at this point in the history

  2. Change comments

    @SantosGuillamot
    SantosGuillamot committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    1855e5d View commit details
    Browse the repository at this point in the history

  3. Change function name

    @SantosGuillamot
    SantosGuillamot committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    4e77262 View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2024

  1. Change processor name and args

    @SantosGuillamot
    SantosGuillamot committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    825f78e View commit details
    Browse the repository at this point in the history