HTML API: Expand Unsupported class and make it available for debugging. #6985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 tasks
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
The HTML Processor internally throws an exception when it reaches HTML that it knows it cannot process, but this exception is not made available to calling code. It can be useful to extract more knowledge about why it gave up, especially for debugging purposes. In this patch, more context is added to the WP_HTML_Unsupported_Exception and the last exception is made available to calling code, if it asks.
dmsnell
force-pushed
the
html-api/expand-exception-information
branch
from
5888586
to
7999c15
Compare
dmsnell
force-pushed
the
html-api/expand-exception-information
branch
from
48dacc2
to
5799152
Compare
ockham
reviewed
Jul 10, 2024
| @@ -1,4 +1,4 @@ | |||
| <?php | |||
| <?php declare( strict_types=1 ); | |||
There was a problem hiding this comment.
First time I'm seeing this construct! Do we support this in Core?
There was a problem hiding this comment.
Oh not sure. Habit. We probably don't.
It is a bit confusing, because it applies type constraints to calling functions from this file, but not in external calling code which calls the functions found in this file.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
pento
pushed a commit
that referenced
this pull request
Jul 12, 2024
…ugging. The HTML Processor internally throws an exception when it reaches HTML that it knows it cannot process, but this exception is not made available to calling code. It can be useful to extract more knowledge about why it gave up, especially for debugging purposes. In this patch, more context is added to the WP_HTML_Unsupported_Exception and the last exception is made available to calling code through a new method, `get_unsupported_exception()`. Developed in #6985 Discussed in https://core.trac.wordpress.org/ticket/61646 Props bernhard-reiter, dmsnell, jonsurrell. See #61646. git-svn-id: https://develop.svn.wordpress.org/trunk@58714 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
Jul 12, 2024
…ugging. The HTML Processor internally throws an exception when it reaches HTML that it knows it cannot process, but this exception is not made available to calling code. It can be useful to extract more knowledge about why it gave up, especially for debugging purposes. In this patch, more context is added to the WP_HTML_Unsupported_Exception and the last exception is made available to calling code through a new method, `get_unsupported_exception()`. Developed in WordPress/wordpress-develop#6985 Discussed in https://core.trac.wordpress.org/ticket/61646 Props bernhard-reiter, dmsnell, jonsurrell. See #61646. Built from https://develop.svn.wordpress.org/trunk@58714 git-svn-id: http://core.svn.wordpress.org/trunk@58116 1a063a9b-81f0-0310-95a4-ce76da25c4cd
github-actions bot
pushed a commit
to platformsh/wordpress-performance
that referenced
this pull request
Jul 12, 2024
…ugging. The HTML Processor internally throws an exception when it reaches HTML that it knows it cannot process, but this exception is not made available to calling code. It can be useful to extract more knowledge about why it gave up, especially for debugging purposes. In this patch, more context is added to the WP_HTML_Unsupported_Exception and the last exception is made available to calling code through a new method, `get_unsupported_exception()`. Developed in WordPress/wordpress-develop#6985 Discussed in https://core.trac.wordpress.org/ticket/61646 Props bernhard-reiter, dmsnell, jonsurrell. See #61646. Built from https://develop.svn.wordpress.org/trunk@58714 git-svn-id: https://core.svn.wordpress.org/trunk@58116 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Debarghya-Banerjee
pushed a commit
to Debarghya-Banerjee/wordpress-develop
that referenced
this pull request
Jul 18, 2024
…ugging. The HTML Processor internally throws an exception when it reaches HTML that it knows it cannot process, but this exception is not made available to calling code. It can be useful to extract more knowledge about why it gave up, especially for debugging purposes. In this patch, more context is added to the WP_HTML_Unsupported_Exception and the last exception is made available to calling code through a new method, `get_unsupported_exception()`. Developed in WordPress#6985 Discussed in https://core.trac.wordpress.org/ticket/61646 Props bernhard-reiter, dmsnell, jonsurrell. See #61646. git-svn-id: https://develop.svn.wordpress.org/trunk@58714 602fd350-edb4-49c9-b593-d223f7449a82
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trac ticket: Core-61646
The HTML Processor internally throws an exception when it reaches HTML
that it knows it cannot process, but this exception is not made
available to calling code. It can be useful to extract more knowledge
about why it gave up, especially for debugging purposes.
In this patch, more context is added to the WP_HTML_Unsupported_Exception
and the last exception is made available to calling code, if it asks.