HTML API: Implement step_in_caption #7041
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
sirreal
force-pushed
the
html-api/add-in-caption-parsing
branch
from
0e1cc85
to
5732d44
Compare
There was a problem hiding this comment.
I'm not a fan of mushing together the separate groups, but we're close enough to the end of the initial support and these are close enough that I think it's fine.
What I don't like about it is how we have to start remembering and interpreting the spec in our heads as we move through the body of the case. There's already an exception for this in +LI, +DD, +DT, so it's not without precedent.
|
I'd be fine with splitting that up. |
As part of work to add more spec support to the HTML API, this patch adds support for the IN CAPTION insertion mode. This small section of the spec handles rules for the `<caption>` element. Developed in #7041 Discussed in https://core.trac.wordpress.org/ticket/61576 Props: dmsnell, jonsurrell. See #61576. git-svn-id: https://develop.svn.wordpress.org/trunk@58840 602fd350-edb4-49c9-b593-d223f7449a82
As part of work to add more spec support to the HTML API, this patch adds support for the IN CAPTION insertion mode. This small section of the spec handles rules for the `<caption>` element. Developed in WordPress/wordpress-develop#7041 Discussed in https://core.trac.wordpress.org/ticket/61576 Props: dmsnell, jonsurrell. See #61576. Built from https://develop.svn.wordpress.org/trunk@58840 git-svn-id: http://core.svn.wordpress.org/trunk@58236 1a063a9b-81f0-0310-95a4-ce76da25c4cd
As part of work to add more spec support to the HTML API, this patch adds support for the IN CAPTION insertion mode. This small section of the spec handles rules for the `<caption>` element. Developed in WordPress/wordpress-develop#7041 Discussed in https://core.trac.wordpress.org/ticket/61576 Props: dmsnell, jonsurrell. See #61576. Built from https://develop.svn.wordpress.org/trunk@58840 git-svn-id: https://core.svn.wordpress.org/trunk@58236 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Trac ticket: https://core.trac.wordpress.org/ticket/61576
This builds on TABLE support from #6040 (merged here).
HTML5-lib test change (
./vendor/bin/phpunit --group html-api-html5lib-tests, (compared with #6040):This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.