HTML API: Ensure that get_modifiable_text() reads enqueued updates.
#7150
Conversation
When `set_modifiable_text()` was added to the Tag Processor, it was overlooked that the same information could be queried after setting its value and before proceeding to the next token. This means that reads following writes return the wrong value. In this patch, `get_modifiable_text()` will read any enqueued values before reading from the input HTML document to ensure consistency. Follow-up to [58829]. Props dmsnell, ramonopoly.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Trac Ticket MissingThis pull request is missing a link to a Trac ticket. For a contribution to be considered, there must be a corresponding ticket in Trac. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description. More information about contributing to WordPress on GitHub can be found in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
When `set_modifiable_text()` was added to the Tag Processor, it was overlooked that the same information could be queried after setting its value and before proceeding to the next token. This means that reads following writes return the wrong value. In this patch, `get_modifiable_text()` will read any enqueued values before reading from the input HTML document to ensure consistency. Follow-up to [58829]. Props dmsnell, ramonopoly.
dmsnell
force-pushed
the
html-api/get-modifiable-text-read-enqueued-updates
branch
from
4ed33d5
to
db23210
Compare
Trac ticket: Core-61617
When
set_modifiable_text()was added to the Tag Processor, it was overlooked that the same information could be queried after setting its value and before proceeding to the next token.This means that reads following writes return the wrong value.
In this patch,
get_modifiable_text()will read any enqueued values before reading from the input HTML document to ensure consistency.Follow-up to [58829].
Props dmsnell, ramonopoly.