mirrored from git://develop.git.wordpress.org/
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTML API: Add spawn fragment parser method #7348
Draft
sirreal
wants to merge
21
commits into
WordPress:trunk
Choose a base branch
from
sirreal:html-api/add-spawn-fragment-parser-method
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
HTML API: Add spawn fragment parser method #7348
sirreal
wants to merge
21
commits into
WordPress:trunk
from
sirreal:html-api/add-spawn-fragment-parser-method
+412
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 13, 2024
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
sirreal
force-pushed
the
html-api/add-spawn-fragment-parser-method
branch
from
October 10, 2024 15:09
7e0e922
to
8ccd0cb
Compare
sirreal
force-pushed
the
html-api/add-spawn-fragment-parser-method
branch
from
October 11, 2024 08:21
8ccd0cb
to
9ac142f
Compare
This reverts commit ba9e218.
This was referenced Nov 7, 2024
Squashed commit of the following: commit 1cde425 Merge: 05ca2a4 8ad5281 Author: Jon Surrell <sirreal@users.noreply.github.com> Date: Wed Nov 6 20:40:05 2024 +0100 Merge branch 'trunk' into html-api/fix-63390-seek commit 05ca2a4 Author: Jon Surrell <sirreal@users.noreply.github.com> Date: Wed Nov 6 20:29:36 2024 +0100 Remove context-node cases from open elements The context node is not pushed to the stack of open elements, and therefore does not need special handling. commit 75ab9c2 Author: Jon Surrell <sirreal@users.noreply.github.com> Date: Wed Nov 6 20:27:57 2024 +0100 Break at root-node when popping elements on seek The context node is not pushed to the stack of open elements, this code was either doing nothing or incorrect. commit 90eb6e2 Author: Jon Surrell <sirreal@users.noreply.github.com> Date: Wed Nov 6 13:53:15 2024 +0100 Use a temporary bookmark to avoid modifying tag processor internal state commit b95e402 Author: Jon Surrell <sirreal@users.noreply.github.com> Date: Wed Nov 6 13:45:13 2024 +0100 Restore private stack properties to private commit d5a7d5c Author: Jon Surrell <sirreal@users.noreply.github.com> Date: Wed Nov 6 13:40:18 2024 +0100 Rework with tests for fragment and full processors Use a dataprovider to get a factory function for processors commit f7af6e3 Author: Jon Surrell <sirreal@users.noreply.github.com> Date: Wed Nov 6 13:19:58 2024 +0100 Add test seeking from SVG namespace commit 388bf19 Author: Jon Surrell <sirreal@users.noreply.github.com> Date: Wed Nov 6 13:05:34 2024 +0100 Add and improve HTML processor bookmark tests commit d5bf14c Author: Jon Surrell <sirreal@users.noreply.github.com> Date: Wed Nov 6 12:17:47 2024 +0100 Add and improve comments commit d181938 Author: Jon Surrell <sirreal@users.noreply.github.com> Date: Wed Nov 6 12:13:48 2024 +0100 Fix fragment state reset for different context nodes commit 9a0c017 Author: Jon Surrell <sirreal@users.noreply.github.com> Date: Wed Nov 6 12:05:43 2024 +0100 Set parsing namespace correctly when seeking commit 660dc85 Author: Jon Surrell <sirreal@users.noreply.github.com> Date: Wed Nov 6 11:49:21 2024 +0100 Remove condition that may not be necessary This seems related to virutal tokens and it likely covered by the virtual token condition commit 9af204c Author: Jon Surrell <sirreal@users.noreply.github.com> Date: Wed Nov 6 11:47:56 2024 +0100 Assert setting bookmark two This is consisten with the assertion on bookmark one commit 851df38 Author: Jon Surrell <sirreal@users.noreply.github.com> Date: Wed Nov 6 11:47:17 2024 +0100 Fix fragment parser bug that should reset breadcrumbs before seeking commit 6106a56 Author: Jon Surrell <sirreal@users.noreply.github.com> Date: Wed Nov 6 11:46:49 2024 +0100 Use do-while loop to iterate after first check commit 744cf01 Author: Jon Surrell <sirreal@users.noreply.github.com> Date: Wed Nov 6 11:42:42 2024 +0100 Add commentary around state resetting in seek commit cb63bbc Author: Jon Surrell <sirreal@users.noreply.github.com> Date: Tue Nov 5 19:51:29 2024 +0100 Lint: remove empty line commit 737bf92 Author: Jon Surrell <sirreal@users.noreply.github.com> Date: Tue Nov 5 19:49:01 2024 +0100 Restore original bookmark matching commit 89aa01b Author: Jon Surrell <sirreal@users.noreply.github.com> Date: Tue Nov 5 19:47:16 2024 +0100 Fix the issue commit dc3f1e6 Author: Jon Surrell <sirreal@users.noreply.github.com> Date: Tue Nov 5 19:06:23 2024 +0100 try fixes commit 541b4f6 Author: Jon Surrell <sirreal@users.noreply.github.com> Date: Fri Oct 25 23:19:19 2024 +0200 wip commit 5d75bb7 Author: Jon Surrell <sirreal@users.noreply.github.com> Date: Fri Oct 25 23:15:51 2024 +0200 Work on fix commit f9777aa Author: Jon Surrell <sirreal@users.noreply.github.com> Date: Fri Oct 25 22:51:44 2024 +0200 Add failing test case
sirreal
force-pushed
the
html-api/add-spawn-fragment-parser-method
branch
from
November 8, 2024 18:58
9f5a895
to
42f3df4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress
Trac ticket: https://core.trac.wordpress.org/ticket/62357
Add a
spawn_fragment_parser( string $html_fragment )
method. This method must be called when the processor is paused at a#tag
with some strict constraints:#tag
.IFRAME
,SCRIPT
,TITLE
, etc.).This supports work on
set_inner_html
in #7326 and #7742.This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.