Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doc: Discuss GPL Licensing in the contributing document #504

Closed
adamziel opened this issue Jun 2, 2023 · 1 comment · Fixed by #1776
Closed

Doc: Discuss GPL Licensing in the contributing document #504

adamziel opened this issue Jun 2, 2023 · 1 comment · Fixed by #1776
Assignees
@n8finch
Labels
Good First Issue Good for newcomers [Type] Documentation Improvements or additions to documentation

Comments

@adamziel
Copy link
Collaborator

adamziel commented Jun 2, 2023

Let's explain somewhere around the Contributing page what are the implications of contributing to a GPL-licensed project like WordPress Playground:

  • Your contributions are licensed under GPL
  • The GPL license has strong copyleft provisions that ensure all derivative works remain open-source and under the same license terms, thereby promoting a collaborative development environment.
  • The GPL license encourages contributing any changes, bug fixes, or new features back to the original codebase.
  • The GPL license ensures that the project remains free and open-source, not only in terms of cost but also with respect to the freedom to use, modify, and distribute the software.
@adamziel adamziel added [Type] Documentation Improvements or additions to documentation Good First Issue Good for newcomers labels Jun 2, 2023
adamziel added a commit that referenced this issue Jan 29, 2024
@adamziel
Move from wp.data files to wp.zip files
2eaeb87 
Playground used the Emscripten's filepacker.py tool to bundle WordPress
releases as zip files. This caused a lot of problems:

* Filepacker splits WordPress into a `.data` file, with all the bytes
  concatenated as a single blob, and a `.js` file with the map of
  offsets and lengths for each file. Sometimes the browsers would
  invalidate the cache for the `.data` file, but not the `.js` file,
  causing the playground to fail to load.
* The `.js` files had to be patched in the Dockerfile.
* The `.js` files used XHR to load the `.data` files, which required custom
  error handling logic, progress monitoring logic, and even then some of the
  errors were not handled properly – see #504.
* The `.data` loading code required custom loading logic.
* The `.data` files were not stream–loaded. This PR doesn't stream-load the
  `.zip` files either, but that feature may be added in the future using the
  new `@wp-playground/compression-streams` package.

 ## Changes

* The WordPress build process now produces `.zip` files instead of `.data`
  + `.js` files.
* The worker thread now loads WordPress from zip files, including zips from
  arbitrary URLs.
* Query API and Blueprints now accept URLs via the `?wp=` parameter.

 ## Testing instructions

* Confirm all the E2E tests pass
@adamziel adamziel mentioned this issue Jan 29, 2024
Merged
@n8finch n8finch mentioned this issue Sep 17, 2024
Merged
@n8finch
Copy link
Contributor

n8finch commented Sep 17, 2024

Can I be assigned this issue @sejas 🙂, PR is ready here: #1776

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@n8finch n8finch

Labels
Good First Issue Good for newcomers [Type] Documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
2 participants
@adamziel @n8finch