Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add logging support to Playground #1035
Add logging support to Playground #1035
Changes from 5 commits
6b21516
d804cec
8480857
7f2c27a
46542e5
315a622
c23dd92
60aa62f
0923c3e
6d6bdaf
d13033d
194bcbd
b84bdc0
46ca5ee
42e47d8
3ea93c5
b1b1c71
c3e2c77
9eed92f
cabbd9b
5ab98c7
6ec3c4a
c9f0b5c
f28c20a
65dd662
be90919
d0398a3
0650878
a192ceb
06158e7
b14f4a5
d0546aa
451ede1
1d840ed
a3feb32
ef4993b
988a9a5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mu-plugin
is a good initial location for this, but eventually let's switch to usingBasePHP
API calls when that's supported. That way it will also impact errors thrown before this mu-plugin is included.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's missing today?
We can create a PHP.ini file for most settings and define the
ERROR_LOG_FILE
.I'm just not sure about
error_reporting
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should work for error reporting when defined in php.ini before the script starts:
error_reporting = E_ALL
What's missing is stable php.ini support for the web SAPI, I think the php.ini functions we have only reliably work with the CLI SAPI, e.g. when the
main()
function is called.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I started a new issue to track it #1049