Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add logging support to Playground #1035
Add logging support to Playground #1035
Changes from 31 commits
6b21516
d804cec
8480857
7f2c27a
46542e5
315a622
c23dd92
60aa62f
0923c3e
6d6bdaf
d13033d
194bcbd
b84bdc0
46ca5ee
42e47d8
3ea93c5
b1b1c71
c3e2c77
9eed92f
cabbd9b
5ab98c7
6ec3c4a
c9f0b5c
f28c20a
65dd662
be90919
d0398a3
0650878
a192ceb
06158e7
b14f4a5
d0546aa
451ede1
1d840ed
a3feb32
ef4993b
988a9a5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to make this pluggable, maybe as a Constructor argument? This way different runtimes could ship their own global error collecting logic, e.g. the VS Code extension will need highly customized logic that I don't think belongs to this repo. Also, there might be environments where the
window
object exists, and yet it either doesn't provide any useful error information or only provides Playground-unrelated noise – I vaguely remember VS Code might be one of them.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it necessary? What would the constructor argument do?
The logger should be accessible by all environments, so a runtime can submit logs and when we add full support it will also be able to read logs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can merge without that. I'd just eventually move the responsibility for selecting the logging method to the consumer of this API instead of guessing what the environment is.
On the website we'd call something like
collectWindowErrors()
, in web worker that could becollectWorkerErrors()
, and then there could be bindings for service workers, Node workers etc.My point was mostly about exposing a loosely coupled API like
collectWindowErrors(logger)
orcollectPlaygroundErrors(logger, playground);
vs tightly coupledlogger.collectWindowErrors()
logger.addPlaygroundRequestEndListener()
. This would make the Logger class lean and responsible for a single thing, while the "error collectors" could be plentiful, separate, and also provided by other modules.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I refactored the code to match what you described in a3feb32.
Let me know what you think.
collectWindowErrors
runs only in the Website package now.