Fix response header escaping #1050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgrgicak
force-pushed
the
fix/1046-sapi-header-escaping
branch
from
36e7fcb to
7a1a304
Compare
bgrgicak
added
[Type] Bug
|
The fix works, the added test pass, and the only test failure is a known flaky test. Let's merge! 🎉 Thank you so much @bgrgicak! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1046
What is this PR doing?
This PR adds escaping for backslash characters in response headers.
What problem is it solving?
Unescaped backslashes in response headers break the JSON structure inside
headers.jsonwhich causes parsing on headers to break Playground.How is the problem addressed?
Backslashes will be escaped before being sent to the client.
Testing Instructions