Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert changes to the docs build #1226

Merged
merged 4 commits into from
Apr 11, 2024
Merged

Revert changes to the docs build #1226

merged 4 commits into from
Apr 11, 2024

Conversation

adamziel
Copy link
Collaborator

@adamziel adamziel commented Apr 11, 2024

What is this PR doing?

Undoes #1222 and 891bf3e to get the documentation site to build.

I am still unsure why does it sometime fail due to a missing models.json file. Perhaps it skips the build:json part of the process somehow? Let's keep observing the subsequent builds.

@adamziel adamziel requested a review from a team as a code owner April 11, 2024 09:14
Copy link
Collaborator

@bgrgicak bgrgicak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'm not sure how this even worked.

@adamziel adamziel changed the title Fix docs build Revert changes to the docs build Apr 11, 2024
@adamziel adamziel added [Type] Bug An existing feature does not function as intended [Type] Documentation Improvements or additions to documentation labels Apr 11, 2024
@adamziel adamziel merged commit d135caf into trunk Apr 11, 2024
4 checks passed
@adamziel adamziel deleted the fix-docs-build branch April 11, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug An existing feature does not function as intended [Type] Documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants