PHP: Remove addServerGlobalEntry() method, accept $_SERVER as php.run() property #1286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…p called $_SERVER
adamziel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes the public
php.addServerGlobalEntry()method in favor of a new$_SERVERproperty forPHPRequest. The provided$_SERVERentries only affected the nextrun()call so making them a part of therun()argument is more natural.What problem does this solve?
This PR reduces the amount of state stored in the
BasePHPclass, simplifying the PHPProcessManager explorations.Testing instructions
Confirm the unit and e2e tests pass.