Blueprints: Remove setPhpIniEntry step #1288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes the setPhpIniEntry step. It cannot work reliably as setting PHP.ini entries must happen before the PHP is initialized, but Blueprints are executed after PHP is initialized. To set php.ini entries, either customize the php.ini files or use an mu-plugin. ## Testing instructions Run a Blueprint with a setPhpIniEntry step, confirm the Playground still loads without a crash.
adamziel
added
[Type] Enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the
setPhpIniEntrystep. It doesn't work reliably – setting PHP.ini entries must happen before the PHP is initialized, but Blueprints are executed after PHP is initialized. The existing Blueprints will continue to work – the Blueprints compiler will ignore thesetPhpIniEntrystep and issue a console warning to notify the developer.To set php.ini entries, either customize the php.ini files or use an mu-plugin.
Testing instructions
Run a Blueprint with a setPhpIniEntry step, confirm the Playground still runs the rest of the Blueprint.