Browser: Remove setSpawnHandler function from the public API #1303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes the setSpawnHandler from the public API exposed on the web. Keeping it would add a lot of complexity to #1287 and we have a good handler in the worker thread. If this is needed again one day, let's explore restoring it then. ## Testing instrctions * Verify the automated CI checks continue to work * Verify the wp-cli demo continues to work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the setSpawnHandler from the public API exposed on the web. Keeping it would add a lot of complexity to #1287 and we have a good handler in the worker thread. If this is needed again one day, let's explore restoring it then.
Related to #1287
Testing instrctions